Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: initial support for Milvus 2.4.x #6084

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Jul 9, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@bowenliang123 bowenliang123 marked this pull request as ready for review July 9, 2024 06:18
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 9, 2024
@bowenliang123 bowenliang123 changed the title support milvus 2.4 dep: support for Milvus 2.4.x Jul 9, 2024
@bowenliang123
Copy link
Contributor Author

bowenliang123 commented Jul 15, 2024

It could be another timing to bump pymilvus to 2.4 again. cc @takatost @JohnJyong

@crazywoola crazywoola requested a review from JohnJyong July 16, 2024 04:35
@bowenliang123 bowenliang123 force-pushed the pymilvus24 branch 2 times, most recently from 97f8c91 to 7e6d954 Compare July 23, 2024 02:47
@bowenliang123 bowenliang123 changed the title dep: support for Milvus 2.4.x dep: initial support for Milvus 2.4.x Jul 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 29, 2024
@JohnJyong JohnJyong merged commit b414ea4 into langgenius:main Jul 29, 2024
5 checks passed
@bowenliang123 bowenliang123 deleted the pymilvus24 branch July 29, 2024 11:57
@takatost takatost mentioned this pull request Aug 5, 2024
cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants