Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial support for Milvus 2.4.x #3795

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Apr 24, 2024

Description

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 24, 2024
@bowenliang123 bowenliang123 changed the title feat: use milvus 2.4.0 feat: support Milvus 2.4.0 Apr 24, 2024
@dosubot dosubot bot added the 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. label Apr 24, 2024
@bowenliang123
Copy link
Contributor Author

cc @takatost @JohnJyong

@bowenliang123 bowenliang123 changed the title feat: support Milvus 2.4.0 feat: initial support for Milvus 2.4.0 Apr 24, 2024
@bowenliang123 bowenliang123 force-pushed the milvus-240 branch 2 times, most recently from f0222e8 to 93cda5e Compare April 25, 2024 13:08
@takatost takatost requested a review from JohnJyong April 25, 2024 14:31
@crazywoola crazywoola mentioned this pull request Apr 27, 2024
4 tasks
@bowenliang123 bowenliang123 changed the title feat: initial support for Milvus 2.4.0 feat: initial support for Milvus 2.4.x Jun 15, 2024
@bowenliang123
Copy link
Contributor Author

bowenliang123 commented Jun 15, 2024

I have updated the poetry lockfile and merged main branch. It should be ready for merging. @JohnJyong

@takatost
Copy link
Collaborator

Sorry, please fix the conflict.
@JohnJyong, can you help review this?

JohnJyong
JohnJyong previously approved these changes Jun 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 19, 2024
@JohnJyong JohnJyong merged commit bb33ffc into langgenius:main Jun 19, 2024
7 checks passed
@bowenliang123 bowenliang123 deleted the milvus-240 branch June 19, 2024 15:22
bowenliang123 added a commit to bowenliang123/dify that referenced this pull request Jun 20, 2024
takatost pushed a commit that referenced this pull request Jun 20, 2024
…ing to 2.3.x for Linux arm64 installation failure (#5414)
ZhouhaoJiang added a commit that referenced this pull request Jun 20, 2024
* refs/heads/main: (21 commits)
  fix: sentry config float type err (#5416)
  fix: prompt editor insert cursor position (#5415)
  fix: Revert "feat: initial support for Milvus 2.4.x (#3795)" downgrading to 2.3.x for Linux arm64 installation failure (#5414)
  fix: optional parameter missing default value None in http request node (#5413)
  feat: new icons (#5412)
  fix bug: tencent vdb #5378 (#5408)
  Corrected an error in the APi docs (#5398)
  feat: update template (#5395)
  fix: unnecessory data fetch when swithing apps category on explore page (#5155)
  chore: extract retrival method literal values into enum (#5060)
  feat: add log date timezone (#4623)
  docs(api/README): Remove unnecessary `=` (#5380)
  Fix: use new button (#5384)
  refactor: refactor the button component using `forwardRef` (#4379)
  feat: initial support for Milvus 2.4.x (#3795)
  feat: introduce pydantic-settings for config definition and validation (#5202)
  feat: support opensearch approximate k-NN (#5322)
  Add sample environment variables for Aliyun OSS (#5366)
  Fix: multi image preview sign (#5376)
  feat: default timezone to user's local timezone in activate form (#5374)
  ...

# Conflicts:
#	api/config.py
#	api/requirements.txt
@bowenliang123 bowenliang123 mentioned this pull request Jun 20, 2024
4 tasks
XiaoLey pushed a commit to XiaoLey/dify that referenced this pull request Jun 22, 2024
…" downgrading to 2.3.x for Linux arm64 installation failure (langgenius#5414)
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
HuberyHuV1 pushed a commit to HuberyHuV1/dify that referenced this pull request Jul 22, 2024
…" downgrading to 2.3.x for Linux arm64 installation failure (langgenius#5414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants