fix: Revert "feat: initial support for Milvus 2.4.x (#3795)" downgrading to 2.3.x for Linux arm64 installation failure #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bb33ffc.
bowenliang123
changed the title
dosubot
bot
added
the
size:S
ZhouhaoJiang
added a commit
that referenced
this pull request
Jun 20, 2024
* refs/heads/main: (21 commits) fix: sentry config float type err (#5416) fix: prompt editor insert cursor position (#5415) fix: Revert "feat: initial support for Milvus 2.4.x (#3795)" downgrading to 2.3.x for Linux arm64 installation failure (#5414) fix: optional parameter missing default value None in http request node (#5413) feat: new icons (#5412) fix bug: tencent vdb #5378 (#5408) Corrected an error in the APi docs (#5398) feat: update template (#5395) fix: unnecessory data fetch when swithing apps category on explore page (#5155) chore: extract retrival method literal values into enum (#5060) feat: add log date timezone (#4623) docs(api/README): Remove unnecessary `=` (#5380) Fix: use new button (#5384) refactor: refactor the button component using `forwardRef` (#4379) feat: initial support for Milvus 2.4.x (#3795) feat: introduce pydantic-settings for config definition and validation (#5202) feat: support opensearch approximate k-NN (#5322) Add sample environment variables for Aliyun OSS (#5366) Fix: multi image preview sign (#5376) feat: default timezone to user's local timezone in activate form (#5374) ... # Conflicts: # api/config.py # api/requirements.txt
4 tasks
XiaoLey
pushed a commit
to XiaoLey/dify
that referenced
this pull request
Jun 22, 2024
…" downgrading to 2.3.x for Linux arm64 installation failure (langgenius#5414)
|
Milvus-lite 2.4.8 now supports poetry and arm64 |
|
Yes, I have noticed this change yesterday. Will raise a PR for it soon. |
12 tasks
HuberyHuV1
pushed a commit
to HuberyHuV1/dify
that referenced
this pull request
Jul 22, 2024
…" downgrading to 2.3.x for Linux arm64 installation failure (langgenius#5414)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pymilvus, the Python SDK for Milvus, requiresmilvus-litepackage since 2.4.x. Howevermilvus-litedoes not provide whl prebuite packages for Linux on arm64 (only providing MacOS on arm64). This blocks thepymilvusinstallation. referring to https://pypi.org/project/milvus-lite/2.4.7/#filesmilvus-liteplans to support Linux on arm64 in future versions, Unable to find installation candidates for milvus-lite (2.4.5) milvus-io/milvus-lite#137 (comment)Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsoptionalI have made corresponding changes to the documentationoptionalI have added tests that prove my fix is effective or that my feature worksoptionalNew and existing unit tests pass locally with my changes