fix(api): defer streaming response until referenced variables are updated#30832
fix(api): defer streaming response until referenced variables are updated#30832Nov1c444 merged 2 commits intolanggenius:mainfrom
Conversation
Summary of ChangesHello @QuantumGhost, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where streaming API responses might prematurely send data before conversation variables, modified by a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively addresses an issue where a streaming response could be sent before a referenced conversation variable was updated by a VariableAssignerNode. The fix is well-implemented by introducing a blocks_variable_output method in the v1 VariableAssignerNode, allowing the workflow engine to correctly defer the stream. The addition of a dedicated test case using a new workflow fixture is excellent, as it specifically verifies that the streamed variable chunks contain the updated value, confirming the fix is working as intended. The code is clean, and the test is comprehensive. Great work.
Important
Fixes #<issue number>.Summary
Fix #30831.
Root cause:
VariableAssignerv1 does not overrideblocks_variable_output, so the response streaming coordinator treats it as non-blocking and may start streaming Answer nodes before the conversation variable update is applied.Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods