Skip to content

fix(api): defer streaming response until referenced variables are updated#30832

Merged
Nov1c444 merged 2 commits intolanggenius:mainfrom
QuantumGhost:fix/var-assigner-debug
Jan 12, 2026
Merged

fix(api): defer streaming response until referenced variables are updated#30832
Nov1c444 merged 2 commits intolanggenius:mainfrom
QuantumGhost:fix/var-assigner-debug

Conversation

@QuantumGhost
Copy link
Collaborator

@QuantumGhost QuantumGhost commented Jan 12, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fix #30831.

Root cause: VariableAssigner v1 does not override blocks_variable_output, so the response streaming coordinator treats it as non-blocking and may start streaming Answer nodes before the conversation variable update is applied.

Screenshots

Before After
image image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @QuantumGhost, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where streaming API responses might prematurely send data before conversation variables, modified by a Variable Assigner node, have been fully updated. The core change introduces a mechanism within the VariableAssignerNode to signal when it is actively modifying a variable that is part of the streaming output. This allows the API to defer the streaming of affected variables until their final values are available, thereby ensuring that users receive accurate and up-to-date information in real-time streaming scenarios.

Highlights

  • API Streaming Logic: Added a blocks_variable_output method to the VariableAssignerNode to identify if it modifies specific conversation variables. This new method is crucial for enabling the API to defer streaming responses until these variables are updated, ensuring data consistency.
  • New Workflow Test Fixture: Introduced a new workflow test fixture (test_streaming_conversation_variables_v1_overwrite.yml) that simulates a scenario where a conversation variable is overwritten by a Variable Assigner node, providing a concrete test case for the fix.
  • Unit Test for Deferred Streaming: Implemented a new unit test (test_streaming_conversation_variables_v1_overwrite_waits_for_assignment) to confirm that streaming responses correctly wait for the Variable Assigner node to update referenced conversation variables before emitting the final value, validating the intended behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses an issue where a streaming response could be sent before a referenced conversation variable was updated by a VariableAssignerNode. The fix is well-implemented by introducing a blocks_variable_output method in the v1 VariableAssignerNode, allowing the workflow engine to correctly defer the stream. The addition of a dedicated test case using a new workflow fixture is excellent, as it specifically verifies that the streamed variable chunks contain the updated value, confirming the fix is working as intended. The code is clean, and the test is comprehensive. Great work.

@QuantumGhost QuantumGhost added this to the 1.11.3 milestone Jan 12, 2026
@QuantumGhost QuantumGhost marked this pull request as ready for review January 12, 2026 01:23
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 12, 2026
@QuantumGhost QuantumGhost requested review from Nov1c444 and removed request for laipz8200 January 12, 2026 06:37
Copy link
Contributor

@Nov1c444 Nov1c444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 12, 2026
@Nov1c444 Nov1c444 merged commit b63dfbf into langgenius:main Jan 12, 2026
13 checks passed
@dosubot dosubot bot mentioned this pull request Jan 21, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect streaming response with conversation variables updated by Variable Assigner v1

2 participants