Skip to content

[CORRUPTED] Synthetic Benchmark PR #30832 - fix(api): defer streaming response until referenced variables are updated#397

Open
ofir-frd wants to merge 3 commits intobase_pr_30832_20260121_7032from
corrupted_pr_30832_20260121_7032
Open

[CORRUPTED] Synthetic Benchmark PR #30832 - fix(api): defer streaming response until referenced variables are updated#397
ofir-frd wants to merge 3 commits intobase_pr_30832_20260121_7032from
corrupted_pr_30832_20260121_7032

Conversation

@ofir-frd
Copy link

Benchmark PR langgenius#30832

Type: Corrupted (contains bugs)

Original PR Title: fix(api): defer streaming response until referenced variables are updated
Original PR Description: > [!IMPORTANT]

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Fix langgenius#30831.

Root cause: VariableAssigner v1 does not override blocks_variable_output, so the response streaming coordinator treats it as non-blocking and may start streaming Answer nodes before the conversation variable update is applied.

Screenshots

Before After
image image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

Original PR URL: langgenius#30832

Compliance Violation

  • Rule: Python Code Must Use Modern Type Syntax for Python 3.12+
  • Language: Python
  • File: api/core/workflow/nodes/variable_assigner/v1/node.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants