Skip to content

Fix sample code and test command. #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2016
Merged

Conversation

tshkh8
Copy link

@tshkh8 tshkh8 commented Sep 24, 2016

When I tried with Quick Start, some sample code didn't work.
And, I didn't understand a way of a test using the POST method.

So, I fixed README.md

・Fix sample code.
・Add test command using curl.

@coveralls
Copy link

coveralls commented Sep 24, 2016

Coverage Status

Coverage remained the same at 86.31% when pulling 2798483 on tshkh8:readme_fix into 04f4504 on labstack:master.

@paganotoni
Copy link
Contributor

paganotoni commented Oct 30, 2016

Runt code changes against v3 codebase and works, great job @tshkh8.

@vishr should we merge this into master or v3 ? i would like this to get merged before working on README.md for v3, since @tshkh8 has made good changes here.

Also curl examples work flawlesly, great work @tshkh8.

@vishr vishr merged commit 9032a46 into labstack:master Oct 31, 2016
@vishr
Copy link
Member

vishr commented Oct 31, 2016

@apaganobeleno These changes also need to be carefully copied to website/index.

vishr pushed a commit that referenced this pull request Nov 1, 2016
* [doc] adding graceful documentation and example.

* adding myself to the maintainers list and minor comment formatting change

* [doc] updating code on the guides/context.md and guides/cookies.md to use v3 code.

* [doc] updating error-handling and request to v3 codebase

* [doc] updating templates documentation

* [doc] cleaning hello-world documentation for v3

* [content] adding website index content based on #667
@tshkh8 tshkh8 deleted the readme_fix branch November 2, 2016 02:13
vishr pushed a commit that referenced this pull request Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants