Skip to content

changes README's hello-world example for v3 #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 1, 2016
Merged

changes README's hello-world example for v3 #698

merged 10 commits into from
Nov 1, 2016

Conversation

paganotoni
Copy link
Contributor

@paganotoni paganotoni commented Oct 30, 2016

This PR

cc @vishr

@coveralls
Copy link

coveralls commented Oct 30, 2016

Coverage Status

Coverage remained the same at 84.943% when pulling 1eef1cf on apaganobeleno:v3 into 8b8aac8 on labstack:v3.

@paganotoni paganotoni mentioned this pull request Oct 30, 2016
16 tasks
@paganotoni paganotoni changed the title changes README the hello-world example for v3 changes README's hello-world example for v3 Oct 30, 2016
@coveralls
Copy link

coveralls commented Nov 1, 2016

Coverage Status

Coverage remained the same at 84.845% when pulling 7e5d422 on apaganobeleno:v3 into f720ea1 on labstack:v3.

@paganotoni
Copy link
Contributor Author

@vishr repurposing this PR, it now adds content to the index based on #667 and also changes hello world example.

Is this ok or i should send this PR in a different way ? WDYT ?

@coveralls
Copy link

coveralls commented Nov 1, 2016

Coverage Status

Coverage remained the same at 84.845% when pulling 07fa1c9 on apaganobeleno:v3 into f720ea1 on labstack:v3.

@vishr vishr merged commit 2cb612f into labstack:v3 Nov 1, 2016
@vishr
Copy link
Member

vishr commented Nov 1, 2016

@apaganobeleno Thanks for your support 👍. Is it ok if I ping you for any documentation related work?

@paganotoni
Copy link
Contributor Author

@vishr definitely anyway i could help please ping me, also if you have some code-related issues that could serve as a way to get used to the codebase i would be wiling to help :).

@vishr
Copy link
Member

vishr commented Nov 1, 2016

@apaganobeleno Thanks, there are open issues labeled help wanted and we definitely need people to fix those.

@vishr
Copy link
Member

vishr commented Nov 3, 2016

@apaganobeleno are you available on gitter chat? Question: is v3 readme/index update to latest changes in v2?

@paganotoni
Copy link
Contributor Author

paganotoni commented Nov 4, 2016

@vishr i'm not not on gitter, nos sure i understand the question, you mean if v2 README has been updated ? if so, i've not worked on v2 docs yet.

@vishr
Copy link
Member

vishr commented Nov 4, 2016

@apaganobeleno Sorry for the confusion. Are changes from this PR (#667) applied into v3 README.md/index.md?

@paganotoni
Copy link
Contributor Author

@vishr yes, those changes have been applied to v3.

@paganotoni
Copy link
Contributor Author

@vishr sorry for the confusion, this should have been overwritten by other PR, i was checking in v3 README.md and some changes in the PR are not there.

@vishr
Copy link
Member

vishr commented Nov 8, 2016

@apaganobeleno Do you think we can get them back?

@paganotoni
Copy link
Contributor Author

@vishr sure, i'll work in a PR soon and mention you there, thanks for the heads-up with this.

@vishr
Copy link
Member

vishr commented Nov 8, 2016

Check index.md too. Let's get v3 out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants