Support "lang" parameter for Koncorde filters #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
suggested changes
Dec 16, 2020
|
|
||
| The search query to apply to API keys content, using [ElasticSearch Query DSL](https://www.elastic.co/guide/en/elasticsearch/reference/7.3/query-dsl.html) syntax. | ||
|
|
||
| <SinceBadge version="change-me"/> |
There was a problem hiding this comment.
Suggested change
| <SinceBadge version="change-me"/> | |
| <SinceBadge version="auto-version"/> |
There was a problem hiding this comment.
Other badges must be updated as well
scottinet
changed the title
Njuelle
approved these changes
Dec 22, 2020
rolljee
approved these changes
Dec 23, 2020
Codecov Report
@@ Coverage Diff @@
## 7-dev #575 +/- ##
=======================================
Coverage 87.98% 87.98%
=======================================
Files 32 32
Lines 1456 1456
Branches 259 259
=======================================
Hits 1281 1281
Misses 125 125
Partials 50 50
Continue to review full report at Codecov.
|
rolljee
requested changes
Dec 28, 2020
| console.log(`Successfully deleted ${deleted.length} documents`); | ||
| } catch (error) { | ||
| console.error(error.message); | ||
| } No newline at end of file |
| template: print-result-successes | ||
| expected: | ||
| - "{ _id: 'document_1', _version: 2, status: 200 }" | ||
| - "{ _id: 'document_2', _version: 2, status: 200 }" No newline at end of file |
rolljee
approved these changes
Dec 29, 2020
Aschen
suggested changes
Dec 29, 2020
doc/7/controllers/auth/search-api-keys/snippets/search-api-keys-koncorde.js
Show resolved
Hide resolved
doc/7/controllers/auth/search-api-keys/snippets/search-api-keys-koncorde.js
Show resolved
Hide resolved
| searchApiKeys( | ||
| query: JSONObject = {}, | ||
| options: { from?: number, size?: number } = {} | ||
| options: { from?: number, size?: number, lang?: string } = {} |
There was a problem hiding this comment.
Missing parameter documentation in the method description
Co-authored-by: Adrien Maret <amaret93@gmail.com>
…s-koncorde.js Co-authored-by: Adrien Maret <amaret93@gmail.com>
…s-koncorde.js Co-authored-by: Adrien Maret <amaret93@gmail.com>
Co-authored-by: Adrien Maret <amaret93@gmail.com>
Co-authored-by: Adrien Maret <amaret93@gmail.com>
Co-authored-by: Adrien Maret <amaret93@gmail.com>
Co-authored-by: Adrien Maret <amaret93@gmail.com>
Co-authored-by: Adrien Maret <amaret93@gmail.com>
Co-authored-by: Adrien Maret <amaret93@gmail.com>
Co-authored-by: Adrien Maret <amaret93@gmail.com>
Co-authored-by: Adrien Maret <amaret93@gmail.com>
Aschen
approved these changes
Dec 30, 2020
Njuelle
approved these changes
Jan 4, 2021
Merged
Aschen
added a commit
that referenced
this pull request
Jan 4, 2021
# [7.4.8](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.4.8) (2021-01-04) #### Bug fixes - [ [#573](#573) ] Fix types for Document and CollectionMappings ([Aschen](https://github.com/Aschen)) #### Enhancements - [ [#575](#575) ] Support "lang" parameter for Koncorde filters ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#579](#579) ] Add event type to document notification ([Aschen](https://github.com/Aschen)) - [ [#578](#578) ] Convert bulk controller to TS ([Aschen](https://github.com/Aschen)) - [ [#574](#574) ] Adds a specific error when the request is too big to use the GET verb ([Aschen](https://github.com/Aschen)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since Kuzzle 2.8.0 supports the "lang" parameter to handle Koncorde filters, we need to add it in SDKs for the API methods who accept it.
#570
How should this be manually tested?
...
Other changes
Boyscout
Update ancient links