Adds a specific error when the request is too big to use the GET verb #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoann-Abbes
approved these changes
Dec 11, 2020
Aschen
commented
Dec 11, 2020
…dk-javascript into warn-when-querystring-too-big
xbill82
approved these changes
Dec 15, 2020
Codecov Report
@@ Coverage Diff @@
## 7-dev #574 +/- ##
==========================================
- Coverage 88.36% 88.28% -0.09%
==========================================
Files 32 32
Lines 1444 1451 +7
Branches 252 254 +2
==========================================
+ Hits 1276 1281 +5
- Misses 119 120 +1
- Partials 49 50 +1
Continue to review full report at Codecov.
|
Merged
Aschen
added a commit
that referenced
this pull request
Jan 4, 2021
# [7.4.8](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.4.8) (2021-01-04) #### Bug fixes - [ [#573](#573) ] Fix types for Document and CollectionMappings ([Aschen](https://github.com/Aschen)) #### Enhancements - [ [#575](#575) ] Support "lang" parameter for Koncorde filters ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#579](#579) ] Add event type to document notification ([Aschen](https://github.com/Aschen)) - [ [#578](#578) ] Convert bulk controller to TS ([Aschen](https://github.com/Aschen)) - [ [#574](#574) ] Adds a specific error when the request is too big to use the GET verb ([Aschen](https://github.com/Aschen)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
HTTP headers request field have a size limite: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/431
When using the
document.mGetmethod with thegetverb, you can hit this limit who result in an 431 response with an empty body.Now a specific error is trowed so developers can understand what is wrong