- 
                Notifications
    You must be signed in to change notification settings 
- Fork 17
Support "lang" parameter for Koncorde filters #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 5 commits
      Commits
    
    
            Show all changes
          
          
            22 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      e5fe0ad
              
                Support lang parameter for Konkorde filters
              
              
                Yoann-Abbes 1314356
              
                fix units tests
              
              
                Yoann-Abbes 7eb061c
              
                update sdk link doc
              
              
                Yoann-Abbes ffcc91e
              
                fix links
              
              
                Yoann-Abbes 42209ba
              
                fix badges
              
              
                Yoann-Abbes 1a27b12
              
                Add snippets
              
              
                Yoann-Abbes 72e1f81
              
                fix
              
              
                Yoann-Abbes 8691acc
              
                Fix tests
              
              
                Yoann-Abbes 1434584
              
                Fix commentary
              
              
                Yoann-Abbes 532558e
              
                Merge branch '7-dev' into support-lang-parameter-for-konkorde-filters
              
              
                Yoann-Abbes d3c6fa7
              
                requested changes @rolljee
              
              
                Yoann-Abbes 565f568
              
                Update doc/7/controllers/auth/search-api-keys/index.md
              
              
                Yoann-Abbes 451c476
              
                Update doc/7/controllers/auth/search-api-keys/snippets/search-api-key…
              
              
                Yoann-Abbes 1afb677
              
                Update doc/7/controllers/auth/search-api-keys/snippets/search-api-key…
              
              
                Yoann-Abbes 4a89ead
              
                Update doc/7/controllers/document/delete-by-query/index.md
              
              
                Yoann-Abbes 0f8ed67
              
                Update doc/7/controllers/document/search/index.md
              
              
                Yoann-Abbes 184c86f
              
                Update doc/7/controllers/security/search-users/index.md
              
              
                Yoann-Abbes 94cc6e6
              
                Update doc/7/controllers/security/search-users/index.md
              
              
                Yoann-Abbes 45ce532
              
                Update src/controllers/Document.ts
              
              
                Yoann-Abbes 1b8619e
              
                Update src/controllers/Document.ts
              
              
                Yoann-Abbes 944cd18
              
                Update doc/7/controllers/document/update-by-query/index.md
              
              
                Yoann-Abbes c030418
              
                Update doc/7/controllers/security/search-api-keys/index.md
              
              
                Yoann-Abbes File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -125,7 +125,7 @@ export class AuthController extends BaseController { | |
| */ | ||
| searchApiKeys( | ||
| query: JSONObject = {}, | ||
| options: { from?: number, size?: number } = {} | ||
| options: { from?: number, size?: number, lang?: string } = {} | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing parameter documentation in the method description | ||
| ): Promise<{ | ||
| /** | ||
| * Array of found ApiKeys | ||
|  | @@ -140,6 +140,7 @@ export class AuthController extends BaseController { | |
| action: 'searchApiKeys', | ||
| from: options.from, | ||
| size: options.size, | ||
| lang: options.lang, | ||
| body: query | ||
| }; | ||
|  | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.