Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Release Managers (take two) #868

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Update Release Managers (take two) #868

merged 2 commits into from
Dec 3, 2019

Conversation

justaugustus
Copy link
Member

Proposing the following updates to the Release Managers groups:

Patch Release Team

  • Add Stephen Augustus

Branch Managers

Release Manager Associates

Remove inactive associates:

(This reverts commit 8e9c01b, reversing
changes made to e7d102f.)

Signed-off-by: Stephen Augustus saugustus@vmware.com

Supersedes #866 and #867.

I'll leave this to lazy consensus and set a date to merge for Tuesday, December 3rd.
/hold

/assign @tpepper @calebamiles
@kubernetes/sig-release-admins @kubernetes/release-engineering @kubernetes/release-managers
/milestone v1.18
/priority important-longterm
/kind feature cleanup

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 24, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 24, 2019
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 24, 2019
@justaugustus justaugustus mentioned this pull request Nov 24, 2019
Merged
cpanato
cpanato approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2019
@guineveresaenger
Copy link
Contributor

/honk
/lgtm

@k8s-ci-robot
Copy link
Contributor

@guineveresaenger:
goose image

In response to this:

/honk
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cblecker
Copy link
Member

+1 honk

@idealhack
Copy link
Member

Mostly LGTM, kindly remind that don’t forget to update the GitHub teams :)

feiskyer
feiskyer approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onlydole
Copy link
Member

😄

image

@justaugustus justaugustus mentioned this pull request Nov 25, 2019
Merged
dougm
dougm reviewed Nov 25, 2019
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xmudrii
Copy link
Member

xmudrii commented Nov 25, 2019

+1

@SlickNik
Copy link
Contributor

/lgtm

@justaugustus
Copy link
Member Author

Discussed any remaining concerns on today's SIG Release call.
We should be good to go on this, but I'll leave it til tomorrow to lift the hold here.

@tpepper
Copy link
Member

tpepper commented Dec 2, 2019

/lgtm

I'm concerned we've not sufficiently activated associates (low percentage engagement and promotion to branch manager), especially through active mentorship. With Stephen moving to patch release, and a very busy person, that need for more active mentors fall onto Carlos and Sascha so satisfy relative to the remaining associates.

We are a bit top heavy on patch release team, versus branch manager team, and this adds one more to patch release at the cost of one less branch manager. Patch release is fairly low volume work, but since it's higher stakes it may be reasonable to have a solid list of prepared folks well prepared to crank out an urgent release if needed. It's also reasonable for Stephen to practice for a period first hand how the patch release team operations.

Maybe we should consider formalizing that patch release managers are also expected to be branch managers now, where they were historically focused on a more trailing set of support tasks?

@justaugustus
Revert "Merge pull request kubernetes#867 from kubernetes/revert-866-…
3ffaa9a 
…relmgr"

This reverts commit 8e9c01b, reversing
changes made to e7d102f.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2019
@justaugustus
releng: Update OWNERS
40b35f2 
- Promote Stephen Augustus to Patch Release Team
- Retroactively add Carlos Panato as Branch Manager
- Promote Sascha Grunert as Branch Manager
- Remove Cheryl Fong as Branch Manager

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus justaugustus mentioned this pull request Dec 2, 2019
Merged
@tpepper
Copy link
Member

tpepper commented Dec 2, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dougm, guineveresaenger, justaugustus, SlickNik, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justaugustus,tpepper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

saschagrunert
saschagrunert approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again 🙏

This was referenced Dec 3, 2019
Merged
Merged
Merged
@justaugustus
Copy link
Member Author

...and away we go! 🚀 :shipit:
/hold cancel
/honk

@k8s-ci-robot
Copy link
Contributor

@justaugustus:
goose image

In response to this:

...and away we go! 🚀 :shipit:
/hold cancel
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9b5ce04 into kubernetes:master Dec 3, 2019
This was referenced Dec 4, 2019
Merged
Closed
@saschagrunert saschagrunert mentioned this pull request Dec 7, 2019
Closed
13 tasks
@cpanato cpanato mentioned this pull request Dec 7, 2019
Closed
13 tasks
@jeremyrickard jeremyrickard mentioned this pull request Jan 27, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm left review comments

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@feiskyer feiskyer feiskyer approved these changes

@guineveresaenger guineveresaenger Awaiting requested review from guineveresaenger

@jberkus jberkus Awaiting requested review from jberkus

Assignees

@dougm dougm

@SlickNik SlickNik

@calebamiles calebamiles

@tpepper tpepper

@cpanato cpanato

@guineveresaenger guineveresaenger

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.