Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: Update release-managers Slack user group #4284

Merged
merged 2 commits into from
Dec 4, 2019
Merged

releng: Update release-managers Slack user group #4284

merged 2 commits into from
Dec 4, 2019

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Dec 3, 2019 •
edited
Loading

Syncing up the Slack user group with the current set of Release Managers.

Signed-off-by: Stephen Augustus saugustus@vmware.com

On hold until kubernetes/sig-release#868 merges
/hold

/assign @tpepper @calebamiles
@kubernetes/sig-release-admins @kubernetes/release-engineering @kubernetes/release-managers
/milestone v1.18
/priority important-longterm
/kind feature cleanup

@k8s-ci-robot
Copy link
Contributor

@justaugustus: The provided milestone is not valid for this repository. Milestones in this repository: [August, Next]

Use /milestone clear to clear the milestone.

In response to this:

Syncing up the Slack user group with the current set of Release Managers.

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @tpepper @calebamiles
@kubernetes/sig-release-admins @kubernetes/release-engineering @kubernetes/release-managers
/milestone v1.18
/priority important-longterm
/kind feature cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Dec 3, 2019
@justaugustus
Copy link
Member Author

On hold until kubernetes/sig-release#868 merges
/hold

@justaugustus
Copy link
Member Author

/assign @alejandrox1 @Katharine @mrbobbytables

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@justaugustus
Copy link
Member Author

kubernetes/sig-release#868 has merged.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@tpepper
Copy link
Member

tpepper commented Dec 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2019
Katharine
Katharine reviewed Dec 3, 2019
View reviewed changes
communication/slack-config/users.yaml Outdated Show resolved Hide resolved
communication/slack-config/usergroups.yaml Outdated Show resolved Hide resolved
@justaugustus
slack: Move SIG Release User Groups to SIG Release subdirectory
b2d14dd 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
releng: Update release-managers Slack User Group
f5e6d21 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Dec 4, 2019
idealhack
idealhack approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@idealhack idealhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idealhack, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@Katharine
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 06d4e19 into kubernetes:master Dec 4, 2019
@justaugustus justaugustus mentioned this pull request Dec 4, 2019
Merged
@saschagrunert saschagrunert mentioned this pull request Dec 7, 2019
Closed
13 tasks
@cpanato cpanato mentioned this pull request Dec 7, 2019
Closed
13 tasks
@jeremyrickard jeremyrickard mentioned this pull request Jan 27, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katharine Katharine Katharine left review comments

@idealhack idealhack idealhack approved these changes

@castrojo castrojo Awaiting requested review from castrojo

@jdumars jdumars Awaiting requested review from jdumars

Assignees

@Katharine Katharine

@calebamiles calebamiles

@tpepper tpepper

@mrbobbytables mrbobbytables

@alejandrox1 alejandrox1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@justaugustus @k8s-ci-robot @tpepper @Katharine @idealhack @calebamiles @mrbobbytables @alejandrox1