Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: Update Release Managers #1440

Merged
merged 4 commits into from
Dec 3, 2019
Merged

releng: Update Release Managers #1440

merged 4 commits into from
Dec 3, 2019

Conversation

justaugustus
Copy link
Member

Accompanying GitHub team membership changes to kubernetes/sig-release#868.

Patch Release Team

  • Add Stephen Augustus

Branch Managers

Release Manager Associates

Remove inactive associates:

Signed-off-by: Stephen Augustus saugustus@vmware.com

On hold until kubernetes/sig-release#868 merges
/hold

/assign @tpepper @calebamiles
@kubernetes/sig-release-admins @kubernetes/release-engineering @kubernetes/release-managers
/milestone v1.18
/priority important-longterm
/kind feature cleanup

@justaugustus
releng: Promote Sascha Grunert to Branch Manager
a0f6247 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
releng: Remove Cheryl Fong from Branch Managers
b19db94 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
releng: Remove inactive Release Manager Associates
531253c 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
releng: Promote Stephen Augustus to Patch Release Team
fe7a393 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2019
@k8s-ci-robot
Copy link
Contributor

@justaugustus: You must be a member of the kubernetes/owners GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your GitHub Admin Team and have them propose you as an additional delegate for this responsibility.

In response to this:

Accompanying GitHub team membership changes to kubernetes/sig-release#868.

Patch Release Team

  • Add Stephen Augustus

Branch Managers

Release Manager Associates

Remove inactive associates:

Signed-off-by: Stephen Augustus saugustus@vmware.com

On hold until kubernetes/sig-release#868 merges
/hold

/assign @tpepper @calebamiles
@kubernetes/sig-release-admins @kubernetes/release-engineering @kubernetes/release-managers
/milestone v1.18
/priority important-longterm
/kind feature cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2019
@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2019
@saschagrunert
Copy link
Member

LGTM! :)

imkin
imkin reviewed Nov 26, 2019
View reviewed changes
config/kubernetes/sig-release/teams.yaml
- hoegaarden # subproject owner / Patch Release Team
- idealhack # Patch Release Team
- imkin # Release Manager Associate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had like to stay on this and contribute.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving forward here. Discussed this w/ Dhawal offline.

@SlickNik
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2019
@justaugustus
Copy link
Member Author

kubernetes/sig-release#868 has merged.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit cede2fc into kubernetes:master Dec 3, 2019
@justaugustus justaugustus mentioned this pull request Dec 4, 2019
Merged
@saschagrunert saschagrunert mentioned this pull request Dec 7, 2019
Closed
13 tasks
@jeremyrickard jeremyrickard mentioned this pull request Jan 27, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imkin imkin imkin left review comments

@nikhita nikhita Awaiting requested review from nikhita

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@SlickNik SlickNik

@calebamiles calebamiles

@tpepper tpepper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@justaugustus @k8s-ci-robot @saschagrunert @SlickNik @imkin @calebamiles @tpepper