Prevent registry-creds configure from failing when a secret does not exist.

[akshaysu12]

…l when a secret does not exist.

closes #5885

[k8s-ci-robot]

Welcome @akshaysu12!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @akshaysu12. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akshaysu12
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[tstromberg]

At a minimum, this should log or display an error rather than hide it entirely. I'm not exactly sure which is appropriate here, but naively glog.Errorf?

[akshaysu12]

Thanks, logging makes sense. I feel a glog.Infof would be most appropriate as I don't think it should be an error when CreateSecrets is unable to get a secret it is going to create.

[RA489]

/ok-to-test

[minikube-pr-bot]

Error: running mkcmp: exit status 1

[codecov-io]

Codecov Report

Merging #6380 into master will decrease coverage by 0.83%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6380      +/-   ##
==========================================
- Coverage    38.3%   37.46%   -0.84%     
==========================================
  Files         124      128       +4     
  Lines        8355     8646     +291     
==========================================
+ Hits         3200     3239      +39     
- Misses       4737     4988     +251     
- Partials      418      419       +1

Impacted Files	Coverage Δ
pkg/minikube/service/service.go	77.83% <0%> (ø)	⬆️
pkg/minikube/cruntime/cri.go	38.57% <0%> (-20.47%)	⬇️
pkg/minikube/cruntime/docker.go	37.6% <0%> (-6.15%)	⬇️
pkg/minikube/bootstrapper/bsutil/binaries.go	10.52% <0%> (-2.81%)	⬇️
pkg/minikube/config/profile.go	67.32% <0%> (-2.78%)	⬇️
pkg/minikube/bootstrapper/bsutil/kubeadm.go	80.95% <0%> (-2.1%)	⬇️
pkg/minikube/cruntime/crio.go	46.87% <0%> (-2.04%)	⬇️
pkg/minikube/cruntime/containerd.go	45.37% <0%> (-1.75%)	⬇️
pkg/minikube/cluster/cluster.go	38.18% <0%> (-1.66%)	⬇️
pkg/minikube/assets/vm_assets.go	35.96% <0%> (-1.54%)	⬇️
... and 19 more

[medyagh]

OK to test

[tstromberg]

/ok-to-test