Skip to content

Commit

Permalink
Update create secret in service so registry creds add on does not fai…
Browse files Browse the repository at this point in the history
…l when a secret does not exist.
  • Loading branch information
akshay-subram committed Jan 23, 2020
1 parent 5fa7935 commit fc3d288
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions pkg/minikube/service/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -332,10 +332,7 @@ func CreateSecret(namespace, name string, dataValues map[string]string, labels m
return &retry.RetriableError{Err: err}
}
secrets := client.Secrets(namespace)
secret, err := secrets.Get(name, meta.GetOptions{})
if err != nil {
return &retry.RetriableError{Err: err}
}
secret, _ := secrets.Get(name, meta.GetOptions{})

// Delete existing secret
if len(secret.Name) > 0 {
Expand Down

0 comments on commit fc3d288

Please sign in to comment.