Skip to content

Commit

Permalink
Merge pull request #6380 from akshaysu12/UpdateRegistryCredsCreateSecret
Browse files Browse the repository at this point in the history
Prevent registry-creds configure from failing when a secret does not exist.
  • Loading branch information
tstromberg authored Jan 30, 2020
2 parents 4fbc65a + 2ba3116 commit 50c32d2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/minikube/service/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,11 @@ func CreateSecret(namespace, name string, dataValues map[string]string, labels m
if err != nil {
return &retry.RetriableError{Err: err}
}

secrets := client.Secrets(namespace)
secret, err := secrets.Get(name, meta.GetOptions{})
if err != nil {
return &retry.RetriableError{Err: err}
glog.Infof("Failed to retrieve existing secret: %v", err)
}

// Delete existing secret
Expand Down

0 comments on commit 50c32d2

Please sign in to comment.