-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: make sure path to logs directory exists #10806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this PR would help users or would potnetially cause more problems (either adding tiny performance issues on slow disks) since it is gets called on each log run.
or maybe permission issues if 755 is not allowed by the admin. i think this only affects the integration tests. that could be fixed there?
thank you for your review and comments @medyagh |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, prezha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #10804
the error description is in the issue, here is a small fix to make sure the path to the directory exists before calling os.OpenFile