Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make sure path to logs directory exists #10806

Merged
merged 3 commits into from
Mar 23, 2021
Merged

test: make sure path to logs directory exists #10806

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7958d67
make sure directory exists
prezha Mar 13, 2021
2965433
make sure logs directory exists
prezha Mar 18, 2021
badcfe2
make sure logs directory exists
prezha Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/minikube/audit/logFile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package audit
import (
"fmt"
"os"
"path/filepath"

"k8s.io/minikube/pkg/minikube/localpath"
"k8s.io/minikube/pkg/minikube/out/register"
Expand All @@ -30,6 +31,9 @@ var currentLogFile *os.File
// setLogFile sets the logPath and creates the log file if it doesn't exist.
func setLogFile() error {
lp := localpath.AuditLog()
if err := os.MkdirAll(filepath.Dir(lp), 0755); err != nil {
prezha marked this conversation as resolved.
Show resolved Hide resolved
return fmt.Errorf("unable to create directory: %w", err)
}
f, err := os.OpenFile(lp, os.O_APPEND|os.O_CREATE|os.O_RDWR, 0644)
if err != nil {
return fmt.Errorf("unable to open %s: %v", lp, err)
Expand Down