Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unique error codes for KVM network and docker ip conflict #10841

Merged
merged 5 commits into from
Mar 16, 2021
Merged

unique error codes for KVM network and docker ip conflict #10841

merged 5 commits into from
Mar 16, 2021

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Mar 15, 2021 •
edited
Loading

helps with #10806
and #9907 and #9190

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2021
ilya-zuyev
ilya-zuyev approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@ilya-zuyev ilya-zuyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member Author

medyagh commented Mar 16, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 16, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10841): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10841/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10841/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10841): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10841/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10841/minikube: exec format error

@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10841): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10841/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10841/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10841): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10841/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10841/minikube: exec format error

@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10841): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10841/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10841/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10841): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10841/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10841/minikube: exec format error

@medyagh
Copy link
Member Author

medyagh commented Mar 16, 2021

/retest-this-please

@medyagh medyagh merged commit 0b28cc0 into kubernetes:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-zuyev ilya-zuyev ilya-zuyev approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@medyagh @k8s-ci-robot @minikube-pr-bot @ilya-zuyev