Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes/klog
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.3
Choose a base ref
...
head repository: kubernetes/klog
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.4.0
Choose a head ref
  • 19 commits
  • 8 files changed
  • 7 contributors

Commits on Jun 14, 2019

  1. Code Hygene - glog to klog 

    Cleaning house a bit and changing the work 'glog' to 'klog' in
a few places.
    chrislovecnm committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    a4033db View commit details
    Browse the repository at this point in the history

  2. Merge pull request #71 from chrislovecnm/glog-to-klog-cleanup 

    Code Hygiene - glog to klog
    @k8s-ci-robot
    k8s-ci-robot authored Jun 14, 2019
    Configuration menu
    Copy the full SHA
    e153094 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. correct documentation

    @BenTheElder
    BenTheElder committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    7c58910 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #73 from BenTheElder/six-year-old-bad-docs 

    correct documentation
    @k8s-ci-robot
    k8s-ci-robot authored Jun 27, 2019
    Configuration menu
    Copy the full SHA
    05be6e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Add flag to include file's dir in logs 

    Signed-off-by: Vince Prignano <vincepri@vmware.com>
    @vincepri
    vincepri committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    b33ae69 View commit details
    Browse the repository at this point in the history

  2. Add go modules files 

    Signed-off-by: Vince Prignano <vincepri@vmware.com>
    @vincepri
    vincepri committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    07b218b View commit details
    Browse the repository at this point in the history

  3. Merge pull request #74 from vincepri/directory-header 

    Add flag to include file's dir in logs
    @k8s-ci-robot
    k8s-ci-robot authored Jul 9, 2019
    Configuration menu
    Copy the full SHA
    aeddeec View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. Merge pull request #75 from vincepri/gomod 

    Add go modules files
    @k8s-ci-robot
    k8s-ci-robot authored Jul 18, 2019
    Configuration menu
    Copy the full SHA
    640c1bd View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. fix broken links

    @fatsheep9146
    fatsheep9146 authored Jul 19, 2019
    Configuration menu
    Copy the full SHA
    baef93d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #77 from fatsheep9146/patch-1 

    fix broken links
    @k8s-ci-robot
    k8s-ci-robot authored Jul 19, 2019
    Configuration menu
    Copy the full SHA
    6a023d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Backfill integration tests for selecting log destinations 

    These tests test the flags
- -log_dir
- -log_file
- -logtostderr
- -alsologtostderr
- -stderrthreshold
and how they play together
    @hoegaarden
    hoegaarden committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    dc5546c View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2019

  1. Merge pull request #80 from pivotal-k8s/e2e_log_dest 

    Backfill integration tests for selecting log destinations
    @k8s-ci-robot
    k8s-ci-robot authored Aug 4, 2019
    Configuration menu
    Copy the full SHA
    ab4d90c View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. Fix the log duplication issue for --log-file 

    when we use a `log-file`, all the items in l.file array point to the
same file. we are currently using a switch statement with fallthrough
which ends up logging the same line multiple times. So check if we are
using a `log-file` and just write the data once.

Change-Id: I3396558f487daf9db2c5e21e29a7a6bee618d64a
    @dims
    dims committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    bf4884f View commit details
    Browse the repository at this point in the history

  2. Test with golang 1.12.x

    @dims
    dims committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    34123a4 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #82 from dims/test-with-golang-1.12.x 

    Test with golang 1.12.x
    @k8s-ci-robot
    k8s-ci-robot authored Aug 5, 2019
    Configuration menu
    Copy the full SHA
    d6788eb View commit details
    Browse the repository at this point in the history

  4. Prevent data race in SetOutput* methods

    @dims
    dims committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    959d342 View commit details
    Browse the repository at this point in the history

  5. Add test case for detecting data race

    @dims
    dims committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    47ffc4e View commit details
    Browse the repository at this point in the history

  6. Merge pull request #83 from dims/prevent-data-race-in-setoutput-and-f… 

    …irends

Prevent data race in SetOutput* methods
    @k8s-ci-robot
    k8s-ci-robot authored Aug 5, 2019
    Configuration menu
    Copy the full SHA
    13d88a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Merge pull request #78 from dims/dedup-log-attempt-2 

    Fix the log duplication issue for --log-file
    @k8s-ci-robot
    k8s-ci-robot authored Aug 7, 2019
    Configuration menu
    Copy the full SHA
    3ca30a5 View commit details
    Browse the repository at this point in the history
Loading