-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent data race in SetOutput* methods #83
Prevent data race in SetOutput* methods #83
Conversation
/assign @neolit123 @miekg can you please check if this patch fixes the problem that you see? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
on the DIFF. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel removing hold as i have added a test case that recreates the problem :) |
Looks sane to me. I'll try when I have a chance.
Thanks!
…On Mon, 5 Aug 2019, 17:13 Kubernetes Prow Robot, ***@***.***> wrote:
Merged #83 <#83> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#83?email_source=notifications&email_token=AACWIWYF2MNGBRTSOQDWD7TQDA7TBA5CNFSM4IJL2KO2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS4D42NA#event-2533870900>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACWIW2QHN2MA3DMJHQYAELQDA7TBANCNFSM4IJL2KOQ>
.
|
New version to get the fix for: kubernetes/klog#83 which can fix: #3055 Signed-off-by: Miek Gieben <miek@miek.nl>
New version to get the fix for: kubernetes/klog#83 which can fix: #3055 Signed-off-by: Miek Gieben <miek@miek.nl>
SetOutput/SetOutputBySeverity should use the mutex intended to protect the
file
flushSyncWriter array.What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #81
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: