Prevent data race in SetOutput* methods #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
approved
|
/assign @neolit123 @miekg can you please check if this patch fixes the problem that you see? |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel removing hold as i have added a test case that recreates the problem :) |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Looks sane to me. I'll try when I have a chance.
Thanks!
…On Mon, 5 Aug 2019, 17:13 Kubernetes Prow Robot, ***@***.***> wrote:
Merged #83 <#83> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#83?email_source=notifications&email_token=AACWIWYF2MNGBRTSOQDWD7TQDA7TBA5CNFSM4IJL2KO2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS4D42NA#event-2533870900>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACWIW2QHN2MA3DMJHQYAELQDA7TBANCNFSM4IJL2KOQ>
.
|
miekg
added a commit
to coredns/coredns
that referenced
this pull request
Aug 10, 2019
New version to get the fix for: kubernetes/klog#83 which can fix: #3055 Signed-off-by: Miek Gieben <miek@miek.nl>
miekg
added a commit
to coredns/coredns
that referenced
this pull request
Aug 10, 2019
New version to get the fix for: kubernetes/klog#83 which can fix: #3055 Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetOutput/SetOutputBySeverity should use the mutex intended to protect the
fileflushSyncWriter array.What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #81
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: