-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct documentation #73
correct documentation #73
Conversation
Welcome @BenTheElder! |
/assign @justinsb |
/lgtm |
Thanks @BenTheElder I tried to figure out what happened. These look like copy-and-pasted comments; the comments are correct on the other methods, but were incorrect on I also agree that we should simple fix the comment instead of changing the behaviour; the behaviour that we have today seems reasonable (even though Println feels relatively redundant ...) /lgtm |
Ah - you already have lgtm; have an approve then! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning, BenTheElder, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks! :-) yeah these functions have quite a bit of overlap but ... 🤷♂ who knows how existing code is depending on this |
What this PR does / why we need it: Fixes the documentation for
.*ln
functions. These erroneously stated that a newline is added if missing, but internally they usefmt.Fprintln
which always appends a'\n'
after the arguments.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: https://golang.org/pkg/fmt/#Fprintln
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: