-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go modules files #75
Conversation
Signed-off-by: Vince Prignano <vincepri@vmware.com>
Do we need these extra files, i.e. what is the drawback if we don't add them? |
If you have go modules enabled, it'll auto-generate these when running go get or any other command, given that k/k has moved to modules in 1.15 I assumed we'd want to do the same here |
We could also add these files to |
I don't think we should ignore these files, Go modules will be on by default in Go 1.13, users updating this repository and adding dependencies will need to add them in here using standard tools for modules, which seems rare. |
Not if we have the files in Sorry, I'm really just trying to understand what difference it makes for users of this package or developers whether we have As an experiment, I just created a dumb test project which uses Go modules and I could add this package with It might be relevant at some point if we start to add dependencies for which we want to record the minimal version, but the files can also be added then. @neolit123: any opinion? |
nowadays, it's a standard practice to enable go modules across k8s repositories. i'm +1 for adding the go files. |
Okay, so let's get onto the bandwagon even if it is just for the sake of it 😄 /lgtm |
/assign @DirectXMan12 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, pohly, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold github search is busted and tide is stuck trying to merge this already-merged PR forever. |
/close |
@vincepri: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
This PR adds
go.mod
andgo.sum
files that get added if you have modules enabled locally.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: