-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add staging project for K8s storage #943
Conversation
we'll be using this to move our existing container images generated by kubernetes incubator. The projects are being shifted from kubernetes incubator to kubernetes-sigs and as part of this migration, we will start using the new image registeries maintained by community infra with GCB + GCS Ref: kubernetes-sigs/nfs-ganesha-server-and-external-provisioner#2 Signed-off-by: kmova <kiran.mova@mayadata.io>
Welcome @kmova! |
Hi @kmova. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM.. Thanks ! |
Signed-off-by: kmova <kiran.mova@mayadata.io>
/ok-to-test I'm actually wondering if it's not too late to migrate the new csi repos to this since the name is broader in scope. cc @pohly do you think that would add too much complexity since the other repos may not use the same release tooling that we have for the csi repos? |
Would it be possible to use a less generic name than storage? If the idea is to have a single group/location for all SIG storage subproject artifacts, my personal preference would be for sig-storage. @thockin @dims @bartsmykla @cblecker do you have any opinions? |
So you want to replace the current |
Yeah, |
Signed-off-by: kmova <kiran.mova@mayadata.io>
renamed |
Signed-off-by: kmova <kiran.mova@mayadata.io>
Signed-off-by: kmova <kiran.mova@mayadata.io>
Yes to having one repository to host all sig-storage sponsored projects. I think the name is fine as well. |
Signed-off-by: kmova <kiran.mova@mayadata.io>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kmova, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ran |
As discussed in kubernetes/k8s.io#943, we want to consolidate all SIG-Storage related work under the new k8s-staging-sig-storage, including the former k8s-staging-csi.
As discussed in kubernetes/k8s.io#943, we want to consolidate all SIG-Storage related work under the new k8s-staging-sig-storage, including the former k8s-staging-csi.
As discussed in kubernetes#943, we want to consolidate all images produced by SIG-storage under k8s-staging-sig-storage, which makes k8s-staging-csi obsolete.
As discussed in kubernetes#943, we want to consolidate all images produced by SIG-storage under k8s-staging-sig-storage, which makes k8s-staging-csi obsolete.
As discussed in kubernetes/k8s.io#943, we want to consolidate under k8s-staging-sig-storage.
registries: | ||
- name: gcr.io/k8s-staging-sig-storage | ||
src: true | ||
- name: us.gcr.io/k8s-artifacts-prod/storage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it intentional or an oversight that the final destination is still "storage" instead of "sig-storage"?
/cc @msau42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was a mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in kubernetes/k8s.io#943, we want to consolidate under k8s-staging-sig-storage.
As discussed in kubernetes/k8s.io#943, we want to consolidate all SIG-Storage related work under the new k8s-staging-sig-storage, including the former k8s-staging-csi.
As discussed in kubernetes/k8s.io#943, we want to consolidate under k8s-staging-sig-storage.
we'll be using this to move our existing container
images generated by kubernetes incubator.
The projects are being shifted from kubernetes incubator
to kubernetes-sigs and as part of this migration,
we will start using the new image registeries maintained
by community infra with GCB + GCS
Ref: kubernetes-sigs/nfs-ganesha-server-and-external-provisioner#2
Signed-off-by: kmova kiran.mova@mayadata.io