Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add staging project for K8s storage #943

Merged
merged 6 commits into from
Jun 10, 2020

Conversation

kmova
Copy link
Contributor

@kmova kmova commented Jun 8, 2020

we'll be using this to move our existing container
images generated by kubernetes incubator.

The projects are being shifted from kubernetes incubator
to kubernetes-sigs and as part of this migration,
we will start using the new image registeries maintained
by community infra with GCB + GCS

Ref: kubernetes-sigs/nfs-ganesha-server-and-external-provisioner#2

Signed-off-by: kmova kiran.mova@mayadata.io

we'll be using this to move our existing container
images generated by kubernetes incubator.

The projects are being shifted from kubernetes incubator
to kubernetes-sigs and as part of this migration,
we will start using the new image registeries maintained
by community infra with GCB + GCS

Ref: kubernetes-sigs/nfs-ganesha-server-and-external-provisioner#2

Signed-off-by: kmova <kiran.mova@mayadata.io>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @kmova!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @kmova. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 8, 2020
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects wg/k8s-infra labels Jun 8, 2020
@kmova
Copy link
Contributor Author

kmova commented Jun 8, 2020

cc: @msau42 @humblec @wongma7

@humblec
Copy link
Contributor

humblec commented Jun 8, 2020

LGTM.. Thanks !

groups/groups.yaml Outdated Show resolved Hide resolved
Signed-off-by: kmova <kiran.mova@mayadata.io>
@msau42
Copy link
Member

msau42 commented Jun 8, 2020

/ok-to-test
This lgtm! Thanks for driving this.

I'm actually wondering if it's not too late to migrate the new csi repos to this since the name is broader in scope. cc @pohly do you think that would add too much complexity since the other repos may not use the same release tooling that we have for the csi repos?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2020
@spiffxp
Copy link
Member

spiffxp commented Jun 9, 2020

Would it be possible to use a less generic name than storage? If the idea is to have a single group/location for all SIG storage subproject artifacts, my personal preference would be for sig-storage. @thockin @dims @bartsmykla @cblecker do you have any opinions?

@pohly
Copy link
Contributor

pohly commented Jun 9, 2020

do you think that would add too much complexity since the other repos may not use the same release tooling that we have for the csi repos?

So you want to replace the current k8s-staging-csi with a different staging area (sig-storage as suggested by spiffxp) also for the CSI repos? I don't see a problem with that. We just push into that staging area with the tooling in csi-release-tools and the other projects use whatever suits them. Promotion to k8s.gcr.io then is a manual process with some support via scripting, just as it is now.

@humblec
Copy link
Contributor

humblec commented Jun 9, 2020

Yeah, sig-storage looks to be a better name than plain storage, so it's better to use it. Hosting the CSI images in this repo would be my choice too. That will avoid much of complications and keep everything in a single place.

Signed-off-by: kmova <kiran.mova@mayadata.io>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 9, 2020
@kmova
Copy link
Contributor Author

kmova commented Jun 9, 2020

renamed storage to sig-storage.

kmova added 2 commits June 9, 2020 12:45
Signed-off-by: kmova <kiran.mova@mayadata.io>
Signed-off-by: kmova <kiran.mova@mayadata.io>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 9, 2020
@spiffxp
Copy link
Member

spiffxp commented Jun 9, 2020

/cc @jsafrane
I'd like to hear from @msau42 or @jsafrane as sig storage TL's to confirm they're ok with this direction

@msau42
Copy link
Member

msau42 commented Jun 9, 2020

Yes to having one repository to host all sig-storage sponsored projects. I think the name is fine as well.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2020
Signed-off-by: kmova <kiran.mova@mayadata.io>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2020
@spiffxp
Copy link
Member

spiffxp commented Jun 10, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmova, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 00693c8 into kubernetes:master Jun 10, 2020
@spiffxp
Copy link
Member

spiffxp commented Jun 10, 2020

Ran ./infra/gcp/ensure-staging-storage.sh sig-storage

pohly added a commit to pohly/test-infra that referenced this pull request Jun 12, 2020
As discussed in kubernetes/k8s.io#943, we want
to consolidate all SIG-Storage related work under the new
k8s-staging-sig-storage, including the former k8s-staging-csi.
pohly added a commit to pohly/test-infra that referenced this pull request Jun 12, 2020
As discussed in kubernetes/k8s.io#943, we want
to consolidate all SIG-Storage related work under the new
k8s-staging-sig-storage, including the former k8s-staging-csi.
pohly added a commit to pohly/k8s.io that referenced this pull request Jun 12, 2020
As discussed in kubernetes#943, we want
to consolidate all images produced by SIG-storage under
k8s-staging-sig-storage, which makes k8s-staging-csi obsolete.
pohly added a commit to pohly/k8s.io that referenced this pull request Jun 12, 2020
As discussed in kubernetes#943, we want
to consolidate all images produced by SIG-storage under
k8s-staging-sig-storage, which makes k8s-staging-csi obsolete.
pohly added a commit to pohly/csi-release-tools that referenced this pull request Jun 12, 2020
As discussed in kubernetes/k8s.io#943, we want
to consolidate under k8s-staging-sig-storage.
registries:
- name: gcr.io/k8s-staging-sig-storage
src: true
- name: us.gcr.io/k8s-artifacts-prod/storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional or an oversight that the final destination is still "storage" instead of "sig-storage"?

/cc @msau42

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was a mistake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a miss from my side @pohly. Raised this PR to fix it. #971

@k8s-ci-robot k8s-ci-robot requested a review from msau42 June 18, 2020 19:09
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/csi-driver-nfs that referenced this pull request Jun 19, 2020
As discussed in kubernetes/k8s.io#943, we want
to consolidate under k8s-staging-sig-storage.
droslean pushed a commit to droslean/test-infra that referenced this pull request Jun 22, 2020
As discussed in kubernetes/k8s.io#943, we want
to consolidate all SIG-Storage related work under the new
k8s-staging-sig-storage, including the former k8s-staging-csi.
shanduur pushed a commit to shanduur/container-object-storage-interface-api that referenced this pull request Jun 6, 2024
As discussed in kubernetes/k8s.io#943, we want
to consolidate under k8s-staging-sig-storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants