Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add staging project for K8s storage #943

Merged
merged 6 commits into from
Jun 10, 2020
Merged

add staging project for K8s storage #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13ec5df
add staging project for K8s storage
kmova Jun 8, 2020
be5d01c
update email address for humblec
kmova Jun 8, 2020
d3e76af
rename storage to sig-storage
kmova Jun 9, 2020
16880cd
add pohly to sig storage group
kmova Jun 9, 2020
2a82301
remove self from owners for now
kmova Jun 9, 2020
fbefa62
add pohly to sig-storage reviewers
kmova Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions groups/groups.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,23 @@ groups:
members:
- bentheelder@google.com

- email-id: k8s-infra-staging-sig-storage@kubernetes.io
name: k8s-infra-staging-sig-storage
description: |-
ACL for staging sig storage artifacts
settings:
ReconcileMembers: "true"
members:
- davanum@gmail.com
- saadali@google.com
- msau@google.com
- xingyang105@gmail.com
- jsafrane@redhat.com
- mattwon@amazon.com
- kiran.mova@mayadata.io
- humble.devassy@gmail.com
kmova marked this conversation as resolved.
Show resolved Hide resolved
- patrick.ohly@intel.com

#
# RBAC groups: k8s-infra-rbac-*
#
Expand Down
1 change: 1 addition & 0 deletions infra/gcp/ensure-staging-storage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ STAGING_PROJECTS=(
scl-image-builder
service-apis
slack-infra
sig-storage
txtdirect
)

Expand Down
14 changes: 14 additions & 0 deletions k8s.gcr.io/images/k8s-staging-sig-storage/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# See the OWNERS docs at https://go.k8s.io/owners

# Current set of people in sig-storage-leads from
# https://github.com/kubernetes/community/blob/master/OWNERS_ALIASES.
approvers:
- jsafrane
- msau42
- saad-ali
- xing-yang

reviewers:
- wongma7
- humblec
kmova marked this conversation as resolved.
Show resolved Hide resolved
- pohly
1 change: 1 addition & 0 deletions k8s.gcr.io/images/k8s-staging-sig-storage/images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# No images yet
10 changes: 10 additions & 0 deletions k8s.gcr.io/manifests/k8s-staging-sig-storage/promoter-manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# google group for gcr.io/k8s-staging-sig-storage is k8s-infra-staging-sig-storage@kubernetes.io
registries:
- name: gcr.io/k8s-staging-sig-storage
src: true
- name: us.gcr.io/k8s-artifacts-prod/storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional or an oversight that the final destination is still "storage" instead of "sig-storage"?

/cc @msau42

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was a mistake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a miss from my side @pohly. Raised this PR to fix it. #971

service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: eu.gcr.io/k8s-artifacts-prod/storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: asia.gcr.io/k8s-artifacts-prod/storage
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com