Migrate kubernetes-incubator/external-storage/nfs #2

kmova · 2020-04-11T18:15:12Z

This PR covers the migration of code from https://github.com/kubernetes-incubator/external-storage/tree/master/nfs to this repo.

The tasks include.

import nfs from external-storage repo (git filter-branch --subdirectory-filter nfs -- --all)
update README.md (3efa64d)
update go import path (eb12c1d)
update with image name and registry location (a1c4fd8)
update vendor (0140304)

With the changes made in this PR, the following build commands work.

make container - generates quay.io/external_storage/nfs-ganesha-server-and-provisioner:latest
make clean

Tasks to be done in future PRs:

Setup the new quay registry location
Refactor E2e
Setup build automation (PROW) to push containers to registry
Update the docs/deployment.md to reflect new/updated testing scenarios.

…ernal-storage

…ut code doc comments

k8s-ci-robot · 2020-04-11T18:17:16Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: kmova <kiran.mova@mayadata.io>

deploy/kubernetes/deployment.yaml

deploy/kubernetes/pod.yaml

deploy/kubernetes/statefulset.yaml

Update Makefile, examples and docs with the new location for the NFS Ganesha Server and Provisioner image. `quay.io/kubernetes_incubator/nfs-provisioner:latest` is changed to `quay.io/external_storage/nfs-ganesha-server-and-provisioner:latest` Signed-off-by: kmova <kiran.mova@mayadata.io>

Signed-off-by: kmova <kiran.mova@mayadata.io>

k8s-ci-robot · 2020-06-03T17:29:24Z

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

bbfd42e Add event list permission to ClusterRole

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kmova · 2020-06-03T17:36:51Z

@jsafrane @msau42 @wongma7 - this is ready for review.

Also, @msau42 - could you help with removing the check of invalid commit similar to kubernetes-sigs/gluster-block-external-provisioner#1 (comment)

wongma7 · 2020-06-03T18:32:34Z

IMO it's not necessary to continue using the quay external_storage org. Can move to docker hub, not use an org at all, or whatever makes sense.

msau42 · 2020-06-03T19:04:05Z

Now we have community infra supported by wg-k8s-infra. I would reach out to them on how to get started. You can also take a look at the kubernetes-csi repos for examples on how to configure the builds. I think we can do that as a second step after getting the initial commits merged.

msau42 · 2020-06-03T19:05:07Z

I've removed the invalid commit message label. I'm not sure how to handle the invalid CLA from the imported commits. @dims do you know?

kmova · 2020-06-05T04:46:13Z

Took the help of linuxfoundation support and found that the issue is with the following older commits, where the github profile doesn't exist now.

msau42 · 2020-06-05T16:41:07Z

Yeah, in the past we have force merged them but I'm not sure of the actual mechanics of how to do that. Is it just having an administrator hit the "Merge pull request" button?

we'll be using this to move our existing container images generated by kubernetes incubator. The projects are being shifted from kubernetes incubator to kubernetes-sigs and as part of this migration, we will start using the new image registeries maintained by community infra with GCB + GCS Ref: kubernetes-sigs/nfs-ganesha-server-and-external-provisioner#2 Signed-off-by: kmova <kiran.mova@mayadata.io>

dims · 2020-06-08T19:57:52Z

@kmova please open a migration issue in https://github.com/kubernetes/org/issues/new/choose and ping the folks on the github admin team https://github.com/kubernetes/community/tree/master/github-management#github-administration-team and they will be able get the changes in.

we'll be using this to move our existing container images generated by kubernetes incubator. The projects are being shifted from kubernetes incubator to kubernetes-sigs and as part of this migration, we will start using the new image registeries maintained by community infra with GCB + GCS Ref: kubernetes-sigs/nfs-ganesha-server-and-external-provisioner#2 Signed-off-by: kmova <kiran.mova@mayadata.io>

kmova · 2020-07-09T14:49:38Z

This PR had an issue with CLA which got resolved and merged via #3

wongma7 and others added 30 commits February 17, 2017 14:31

Move nfs things into nfs directory

2f49318

Move e2e into test

5565502

Move demos-hostpath to top-level docs, nfs to docs/demo

6432a1a

Fix import statements

a788fef

Manually vendor self in

5c8a09e

Fix e2e test hardcoded path

4409c5b

Rename kube-config dir -> kubernetes

90db5c8

Separate authorization (psp,scc,rbac) doc from deployment

c11afb5

Verify golint, vet, & boilerplate

b45903c

Fix boilerplate, golint, govet

6fcc367

Verify library controller code

d6362d0

Update import statements and (most) instances of nfs-provisioner->ext…

7541041

…ernal-storage

Fix nfs-provisioner build by updating vendor

b817b43

Update READMEs

578e689

Fix nfs build

48ee7ef

Update demos (hostpath), docs

c1d1164

Update README.md

bdc1ba3

Use shared top-level vendor directory

3ec4c8c

Fix verify golint

59b2f5e

Release nfs provisioner v1.0.4

2ec8627

Add nfs changelog and efs+nfs release inhfo

6a2744f

Update deployment.md

6618e5b

setgid on efs and nfs

77c8879

Update all provisioners' imports, glide.yaml

5357f84

Update lib controller and all provisioners except NFS tests

bd73d46

Vendor kube e2e framework for nfs, separate from top-level

97e2066

Release nfs v1.0.5

d13e35e

Move DefaultLeaseDuration... parameters to controller pkg and flesh o…

ed51366

…ut code doc comments

Remove non-emptydir nfs provisioner pod option

94f21c5

Add 'list events' to openshift clusterrole examples

3ce9804

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 11, 2020

kmova marked this pull request as draft April 11, 2020 18:15

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 11, 2020

kmova added 2 commits April 12, 2020 12:31

update github references to new repo

eb12c1d

Signed-off-by: kmova <kiran.mova@mayadata.io>

update links/text to new repo in README.md

3efa64d

Signed-off-by: kmova <kiran.mova@mayadata.io>

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2020

ashishranjan738 reviewed Apr 24, 2020

View reviewed changes

deploy/kubernetes/deployment.yaml Outdated Show resolved Hide resolved

ashishranjan738 reviewed Apr 24, 2020

View reviewed changes

deploy/kubernetes/pod.yaml Outdated Show resolved Hide resolved

ashishranjan738 reviewed Apr 24, 2020

View reviewed changes

deploy/kubernetes/statefulset.yaml Outdated Show resolved Hide resolved

kmova added 2 commits June 3, 2020 17:12

add dependencies via go mod vendor

0140304

Signed-off-by: kmova <kiran.mova@mayadata.io>

kmova marked this pull request as ready for review June 3, 2020 17:30

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2020

msau42 removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 3, 2020

kmova mentioned this pull request Jun 8, 2020

add staging project for K8s storage kubernetes/k8s.io#943

Merged

kmova mentioned this pull request Jun 9, 2020

Need help on migration of kubernetes-incubator/external-storage/tree/master/nfs kubernetes/org#1921

Closed

kmova mentioned this pull request Jun 24, 2020

Migrate kubernetes-incubator/external-storage/nfs #3

Merged

6 tasks

kmova closed this Jul 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate kubernetes-incubator/external-storage/nfs #2

Migrate kubernetes-incubator/external-storage/nfs #2

kmova commented Apr 11, 2020 •

edited

Loading

k8s-ci-robot commented Apr 11, 2020

k8s-ci-robot commented Jun 3, 2020

kmova commented Jun 3, 2020

wongma7 commented Jun 3, 2020

msau42 commented Jun 3, 2020

msau42 commented Jun 3, 2020

kmova commented Jun 5, 2020

msau42 commented Jun 5, 2020

dims commented Jun 8, 2020

kmova commented Jul 9, 2020

Migrate kubernetes-incubator/external-storage/nfs #2

Migrate kubernetes-incubator/external-storage/nfs #2

Conversation

kmova commented Apr 11, 2020 • edited Loading

k8s-ci-robot commented Apr 11, 2020

k8s-ci-robot commented Jun 3, 2020

kmova commented Jun 3, 2020

wongma7 commented Jun 3, 2020

msau42 commented Jun 3, 2020

msau42 commented Jun 3, 2020

kmova commented Jun 5, 2020

msau42 commented Jun 5, 2020

dims commented Jun 8, 2020

kmova commented Jul 9, 2020

kmova commented Apr 11, 2020 •

edited

Loading