add github workflow to check supportedFeatures freshness #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/release-note-label-needed
LiorLieberman
force-pushed
the
add-check-for-kubebuilder-validation
branch
from
569a4ca
to
7d365b9
Compare
LiorLieberman
changed the title
k8s-ci-robot
added
release-note-none
LiorLieberman
force-pushed
the
add-check-for-kubebuilder-validation
branch
from
7d365b9
to
916d8c4
Compare
k8s-ci-robot
added
size/M
LiorLieberman
force-pushed
the
add-check-for-kubebuilder-validation
branch
from
c4b5850
to
b40893e
Compare
k8s-ci-robot
added
size/S
levikobi
reviewed
Feb 5, 2024
k8s-ci-robot
added
size/M
LiorLieberman
force-pushed
the
add-check-for-kubebuilder-validation
branch
from
b6b6dab
to
54fd807
Compare
1 task
LiorLieberman
changed the title
LiorLieberman
force-pushed
the
add-check-for-kubebuilder-validation
branch
from
50b0f16
to
ba96bfe
Compare
|
Thanks @LiorLieberman! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
/area conformance
What this PR does / why we need it:
Kubebuilder validation gets out of date is someone is adding a supportedFeature.
When a gateway controller publish supportedFeatures into the GWC, the validation blocks it if some features are not in that list.
Right now, suite.AllFeatures contains features that are not in the validation.
Which issue(s) this PR fixes:
This enables the implementation of #2163 in gateway controllers by fixing the discrepancy between the validation list and the actual features.
It also keep freshness of this kubebuilder validation list
Does this PR introduce a user-facing change?: