Skip to content

Commit

Permalink
add github workflow to check supportedFeatures freshness
Browse files Browse the repository at this point in the history
  • Loading branch information
LiorLieberman committed Feb 5, 2024
1 parent d604611 commit 7d365b9
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 1 deletion.
27 changes: 27 additions & 0 deletions .github/workflows/supported_features.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: 'kubebuilder-supported-features-freshness'
on:
pull_request:
branches:
- main
- master
paths:
- 'conformance/utils/suite/**'
jobs:
checker:
runs-on: ubuntu-latest
steps:
- name: 'checkout'
uses: actions/checkout@v4
- name: 'check_diff'
run: |
RED='\033[0;31m'
GREEN='\033[0;32m'
NC='\033[0m
current_features=$(grep -B 1 'type SupportedFeature string' apis/v1/gatewayclass_types.go | grep -oP '// \+kubebuilder:validation:Enum=\K.*')
expected_features=$(go run hack/supportedfeatures/main.go)
if [[ "$current_features" != "$expected_features" ]]; then
echo "found diff between the current and the expected supportedFeatures"
echo -e "expected: ${GREEN}${expected_features}${NC}"
echo "current: ${RED}${current_features}${NC}"
exit 1
fi
2 changes: 1 addition & 1 deletion conformance/utils/suite/features.go
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ var MeshCoreFeatures = sets.New(

// AllFeatures contains all the supported features and can be used to run all
// conformance tests with `all-features` flag.
//
// asd
// NOTE: as new feature sets are added they should be inserted into this set.
var AllFeatures = sets.New[SupportedFeature]().
Insert(GatewayExtendedFeatures.UnsortedList()...).
Expand Down

0 comments on commit 7d365b9

Please sign in to comment.