Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEP 2162 - Supported features in GatewayClass Status #2163

Merged
merged 20 commits into from
Sep 6, 2023
Merged

GEP 2162 - Supported features in GatewayClass Status #2163

merged 20 commits into from
Sep 6, 2023

Conversation

LiorLieberman
Copy link
Member

/kind gep

What this PR does / why we need it:
This GEP proposes changes to GatewayClassStatus API to include the installed GatewayClass supported and unsupported features .

Which issue(s) this PR fixes:

Fixes #2162

Does this PR introduce a user-facing change?:

Allow end-users to see what features their installed GatewayClass support

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2023
@LiorLieberman
Copy link
Member Author

/cc @shaneutt

@shaneutt shaneutt added this to the v1.0.0 milestone Jul 3, 2023
LiorLieberman
LiorLieberman commented Jul 3, 2023
View reviewed changes
geps/gep-2162.md Outdated Show resolved Hide resolved
shaneutt
shaneutt reviewed Jul 3, 2023
View reviewed changes
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
@LiorLieberman LiorLieberman mentioned this pull request Jul 3, 2023
Open
spacewander
spacewander reviewed Jul 4, 2023
View reviewed changes
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
robscott
robscott reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman! A few comments but otherwise LGTM.

geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
pleshakov
pleshakov reviewed Jul 5, 2023
View reviewed changes
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
mlavacca
mlavacca reviewed Jul 11, 2023
View reviewed changes
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Show resolved Hide resolved
mlavacca
mlavacca reviewed Jul 11, 2023
View reviewed changes
geps/gep-2162.md Outdated Show resolved Hide resolved
howardjohn
howardjohn suggested changes Jul 11, 2023
View reviewed changes
geps/gep-2162.md Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
@pleshakov pleshakov mentioned this pull request Jul 13, 2023
Merged
6 tasks
@LiorLieberman
Copy link
Member Author

/retest

robscott
robscott reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman! This mostly LGTM.

geps/gep-2162.md Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Show resolved Hide resolved
youngnick
youngnick reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good to me aside from some small language clarifications and the already-discussed move to a single list of features.

geps/gep-2162.md Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
robscott
robscott reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman!

geps/gep-2162.md Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
youngnick
youngnick reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay for Provisional to me, although I do think that the feature name and conformance test audit is probably necessary before we go too much further.

geps/gep-2162.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2023
robscott
robscott reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman! A few nits but mostly non blocking.

/approve

geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
geps/gep-2162.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robscott robscott added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 29, 2023
@youngnick
Copy link
Contributor

LGTM for provisional, but I won't do the command until @robscott's changes are done.

LiorLieberman and others added 2 commits August 30, 2023 13:45
@LiorLieberman @robscott
Apply suggestions from code review
8ccd8c2 
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
@LiorLieberman
add feature tables to future work
cc8018c
@robscott
Copy link
Member

robscott commented Sep 6, 2023

Thanks @LiorLieberman!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit df2d1d4 into kubernetes-sigs:main Sep 6, 2023
4 checks passed
@LiorLieberman LiorLieberman mentioned this pull request Sep 8, 2023
Closed
@shaneutt shaneutt mentioned this pull request Sep 18, 2023
Closed
@robscott robscott mentioned this pull request Oct 9, 2023
Merged
@LiorLieberman LiorLieberman mentioned this pull request Oct 26, 2023
Open
@LiorLieberman LiorLieberman mentioned this pull request Feb 5, 2024
Merged
@LiorLieberman LiorLieberman mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@pleshakov pleshakov pleshakov left review comments

@spacewander spacewander spacewander left review comments

@shaneutt shaneutt shaneutt approved these changes

@youngnick youngnick youngnick left review comments

@mlavacca mlavacca mlavacca left review comments

@bowei bowei Awaiting requested review from bowei

@howardjohn howardjohn Awaiting requested review from howardjohn

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

GEP: GatewayClass status supported features
9 participants
@LiorLieberman @k8s-ci-robot @youngnick @robscott @howardjohn @pleshakov @spacewander @shaneutt @mlavacca