Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEP: GatewayClass status supported features #2162

Open
LiorLieberman opened this issue Jul 3, 2023 · 10 comments · Fixed by #2163
Open

GEP: GatewayClass status supported features #2162

LiorLieberman opened this issue Jul 3, 2023 · 10 comments · Fixed by #2163
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP) triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@LiorLieberman
Copy link
Member

What would you like to be added:
Improve UX by enabling them to easily see what features their installed GatewayClass support.

Why this is needed:
With the evolution of the Conformance tests suite and features, we want to;

  1. Enable users easily see what features the implementation support
  2. Improving UX and potentially provide clear errors when a user is trying to use a feature the installed GWC doesn't support

cc: @shaneutt

@LiorLieberman LiorLieberman added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 3, 2023
@LiorLieberman
Copy link
Member Author

/kind gep

@k8s-ci-robot k8s-ci-robot added the kind/gep PRs related to Gateway Enhancement Proposal(GEP) label Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 3, 2023
@LiorLieberman
Copy link
Member Author

/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 3, 2023
@kubernetes-sigs kubernetes-sigs deleted a comment from LiorLieberman Jul 4, 2023
@shaneutt shaneutt added this to the v1.0.0 milestone Jul 4, 2023
@robscott
Copy link
Member

robscott commented Sep 6, 2023

Leaving open until this reaches GA.

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

@robscott: Reopened this issue.

In response to this:

Leaving open until this reaches GA.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaneutt shaneutt removed this from the v1.0.0 milestone Sep 27, 2023
@robscott robscott changed the title Gateway Class status should show supported features GEP: GatewayClass status supported features Dec 2, 2023
@LiorLieberman
Copy link
Member Author

LiorLieberman commented Feb 6, 2024

PRs in flight:
envoyproxy/gateway#2491
istio/istio#48770

@shaneutt
Copy link
Member

shaneutt commented May 7, 2024

We discussed this on a Gateway API sync: it may be helpful if we package in the conformance part in the initial delivery of this, as that might be a helpful way to encourage implementations.

@mikemorris
Copy link
Contributor

mikemorris commented May 11, 2024

@robscott Have you thought about how GKE might handle this (given the whole lack of in-cluster GatewayClass resources approach we share on AKS) if we try to go in the direction of using this advertisement of supported functionality to configure the conformance suite?

EDIT: I was wrong, we do actually deploy a GatewayClass into the cluster (just don't supported a user-defined GatewayClass), so we shouldn't be blocked here.

/cc @snehachhabria

@snehachhabria
Copy link
Contributor

snehachhabria commented May 16, 2024

@robscott Have you thought about how GKE might handle this (given the whole lack of in-cluster GatewayClass resources approach we share on AKS) if we try to go in the direction of using this advertisement of supported functionality to configure the conformance suite?

EDIT: I was wrong, we do actually deploy a GatewayClass into the cluster (just don't supported a user-defined GatewayClass), so we shouldn't be blocked here.

/cc @snehachhabria

that's right, we do have predefined in-cluster GatewayClasses, so no issues form our end.

@LiorLieberman
Copy link
Member Author

For some reason I though I left a comment here but apparently I did not. Anyway, I can confirm that within GKE GatewayClasses are also visible from within the cluster

@arkodg
Copy link
Contributor

arkodg commented Jun 4, 2024

thanks @levikobi for adding support for this in Envoy Gateway ! sharing some thoughts after seeing it in action

  • biggest value prop here is for users who can figure out which features the implementation supports, however just the name is not enough here, and a URL to the feature page would be great here, to make this more actionable and avoid searching how to use the feature
  • the current flat structure if going to get hard to consume for the user soon once we add more support for more things and tests
  • implementations may choose to use this field to highlight any extra features they support, to increase feature usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/gep PRs related to Gateway Enhancement Proposal(GEP) triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Experimental
Development

Successfully merging a pull request may close this issue.

7 participants