-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
httproute: drop default HTTPRouteHost #258
httproute: drop default HTTPRouteHost #258
Conversation
Thanks! Had to double check that we never had examples referencing this field - must indicate that it was never that useful... /lgtm |
/assign @bowei |
/lgtm |
This patch removes default HTTPRouteHost and instead recommends the following two ways to implement default routing behavior: 1. For a catch-all route for a hostname or a subset of hostname, use a `PathMatchType` of `Prefix` with `/` path. 2. For a catch-all route across all hostnames on a given listener, combine (1) with a listener with HostnameMatchType of `Any`.
7cbc4be
to
50c0bfa
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, hbagdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch removes default HTTPRouteHost and instead recommends the
following two ways to implement default routing behavior:
PathMatchType
ofPrefix
with/
path.a listener with
HostnameMatchType
ofAny
.This should fix #255.