Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httproute: drop default HTTPRouteHost #258

Merged

Conversation

hbagdi
Copy link
Contributor

@hbagdi hbagdi commented Aug 7, 2020

This patch removes default HTTPRouteHost and instead recommends the
following two ways to implement default routing behavior:

  1. For a catch-all route for a hostname or a subset of hostname, use a
    PathMatchType of Prefix with / path.
  2. For a catch-all route across all hostnames on a given listener, combine (1) with
    a listener with HostnameMatchType of Any.

This should fix #255.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2020
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 7, 2020
@robscott
Copy link
Member

robscott commented Aug 7, 2020

Thanks! Had to double check that we never had examples referencing this field - must indicate that it was never that useful...

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2020
@robscott
Copy link
Member

robscott commented Aug 7, 2020

/assign @bowei

@bowei
Copy link
Contributor

bowei commented Aug 11, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 11, 2020
This patch removes default HTTPRouteHost and instead recommends the
following two ways to implement default routing behavior:
1. For a catch-all route for a hostname or a subset of hostname, use a
`PathMatchType` of `Prefix` with `/` path.
2. For a catch-all route across all hostnames on a given listener, combine (1) with
a listener with HostnameMatchType of `Any`.
@hbagdi hbagdi force-pushed the feat/drop-default-httproutehost branch from 7cbc4be to 50c0bfa Compare August 12, 2020 00:10
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 12, 2020
@hbagdi
Copy link
Contributor Author

hbagdi commented Aug 12, 2020

@bowei @robscott I rebased, another /lgtm please?

@bowei
Copy link
Contributor

bowei commented Aug 12, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, hbagdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default HTTPRouteHost should be removed from HTTPRoute
4 participants