Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default HTTPRouteHost should be removed from HTTPRoute #255

Closed
robscott opened this issue Aug 6, 2020 · 1 comment · Fixed by #258
Closed

Default HTTPRouteHost should be removed from HTTPRoute #255

robscott opened this issue Aug 6, 2020 · 1 comment · Fixed by #258
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@robscott
Copy link
Member

robscott commented Aug 6, 2020

Since it will be common for Gateways to reference multiple Routes, there's significant potential for messy conflicts. If multiple Routes define a default there does not seem to be an obvious way to choose which default should be applied. This functionality can easily be replicated by a new route rule that matches / with a Prefix type, potentially the default if #254 makes sense. I think as we're approaching an alpha release we should attempt to remove any fields we don't need. This seems to qualify.

For reference, I'm talking about the field defined here: https://github.com/kubernetes-sigs/service-apis/blob/master/apis/v1alpha1/httproute_types.go#L27-L31

@robscott robscott added the kind/bug Categorizes issue or PR as related to a bug. label Aug 6, 2020
@hbagdi
Copy link
Contributor

hbagdi commented Aug 7, 2020

+1 to this change.

If multiple Routes define a default there does not seem to be an obvious way to choose which default should be applied.

The default HTTPRouteHost is similar to Ingress v1's default backend, which has caused this exact problem for implementations which collapse multiple Ingress resources behind a single proxy/Gateway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants