Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default PathType match should be prefix #254

Closed
robscott opened this issue Aug 6, 2020 · 2 comments · Fixed by #260
Closed

Default PathType match should be prefix #254

robscott opened this issue Aug 6, 2020 · 2 comments · Fixed by #260
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@robscott
Copy link
Member

robscott commented Aug 6, 2020

The current default behavior for PathType matching is / + Exact. I think it would be preferable to default to Prefix as the path type matching so by default a rule matches all requests. This would make it easier to initially set up a Gateway + Route combination that routed requests to all paths to a Service. I believe this would also more closely match user expectations when interacting with this API.

@robscott robscott added the kind/bug Categorizes issue or PR as related to a bug. label Aug 6, 2020
@jpeach
Copy link
Contributor

jpeach commented Aug 6, 2020

Yep, I agree that exactly matching / is a pretty unintuitive default :)

@robscott
Copy link
Member Author

robscott commented Aug 7, 2020

Ignore this - just testing:

/milestone v1alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants