httproute: drop default HTTPRouteHost

This patch removes default HTTPRouteHost and instead recommends the following two ways to implement default routing behavior: 1. For a catch-all route for a hostname or a subset of hostname, use a `PathMatchType` of `Prefix` with `/` path. 2. For a catch-all route across all hostnames on a given listener, combine (1) with a listener with HostnameMatchType of `Any`.
kubernetes-sigs · Aug 12, 2020 · 50c0bfa · 50c0bfa
1 parent 54286b5
commit 50c0bfa
Show file tree

Hide file tree

Showing 7 changed files with 128 additions and 438 deletions.
diff --git a/apis/v1alpha1/generated.pb.go b/apis/v1alpha1/generated.pb.go
diff --git a/apis/v1alpha1/generated.proto b/apis/v1alpha1/generated.proto
diff --git a/apis/v1alpha1/httproute_types.go b/apis/v1alpha1/httproute_types.go
@@ -23,12 +23,6 @@ import (
 type HTTPRouteSpec struct {
 	// Hosts is a list of Host definitions.
 	Hosts []HTTPRouteHost `json:"hosts,omitempty" protobuf:"bytes,1,rep,name=hosts"`
-
-	// Default is the default host to use. Default.Hostnames must
-	// be an empty list.
-	//
-	// +optional
-	Default *HTTPRouteHost `json:"default" protobuf:"bytes,2,opt,name=default"`
 }
 
 // HTTPRouteHost is the configuration for a given set of hosts.

diff --git a/apis/v1alpha1/zz_generated.deepcopy.go b/apis/v1alpha1/zz_generated.deepcopy.go
diff --git a/config/crd/bases/networking.x-k8s.io_httproutes.yaml b/config/crd/bases/networking.x-k8s.io_httproutes.yaml
diff --git a/docs-src/spec.md b/docs-src/spec.md
@@ -406,21 +406,6 @@ HTTPRouteSpec
 <p>Hosts is a list of Host definitions.</p>
 </td>
 </tr>
-<tr>
-<td>
-<code>default</code></br>
-<em>
-<a href="#networking.x-k8s.io/v1alpha1.HTTPRouteHost">
-HTTPRouteHost
-</a>
-</em>
-</td>
-<td>
-<em>(Optional)</em>
-<p>Default is the default host to use. Default.Hostnames must
-be an empty list.</p>
-</td>
-</tr>
 </table>
 </td>
 </tr>
@@ -1788,21 +1773,6 @@ HTTPRouteAction
 <p>Hosts is a list of Host definitions.</p>
 </td>
 </tr>
-<tr>
-<td>
-<code>default</code></br>
-<em>
-<a href="#networking.x-k8s.io/v1alpha1.HTTPRouteHost">
-HTTPRouteHost
-</a>
-</em>
-</td>
-<td>
-<em>(Optional)</em>
-<p>Default is the default host to use. Default.Hostnames must
-be an empty list.</p>
-</td>
-</tr>
 </tbody>
 </table>
 <h3 id="networking.x-k8s.io/v1alpha1.HTTPRouteStatus">HTTPRouteStatus

diff --git a/docs/spec/index.html b/docs/spec/index.html
@@ -731,21 +731,6 @@ <h3 id="networking.x-k8s.io/v1alpha1.HTTPRoute">HTTPRoute
 <p>Hosts is a list of Host definitions.</p>
 </td>
 </tr>
-<tr>
-<td>
-<code>default</code></br>
-<em>
-<a href="#networking.x-k8s.io/v1alpha1.HTTPRouteHost">
-HTTPRouteHost
-</a>
-</em>
-</td>
-<td>
-<em>(Optional)</em>
-<p>Default is the default host to use. Default.Hostnames must
-be an empty list.</p>
-</td>
-</tr>
 </table>
 </td>
 </tr>
@@ -2113,21 +2098,6 @@ <h3 id="networking.x-k8s.io/v1alpha1.HTTPRouteSpec">HTTPRouteSpec
 <p>Hosts is a list of Host definitions.</p>
 </td>
 </tr>
-<tr>
-<td>
-<code>default</code></br>
-<em>
-<a href="#networking.x-k8s.io/v1alpha1.HTTPRouteHost">
-HTTPRouteHost
-</a>
-</em>
-</td>
-<td>
-<em>(Optional)</em>
-<p>Default is the default host to use. Default.Hostnames must
-be an empty list.</p>
-</td>
-</tr>
 </tbody>
 </table>
 <h3 id="networking.x-k8s.io/v1alpha1.HTTPRouteStatus">HTTPRouteStatus