⚠️ Add native SSA support#3253
Merged
k8s-ci-robot merged 12 commits intokubernetes-sigs:mainfrom Jul 23, 2025
Merged
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
alvaroaleman
commented
Jul 5, 2025
alvaroaleman
added
the
tide/merge-method-squash
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
JoelSpeed
reviewed
Jul 7, 2025
Contributor
|
/lgtm /hold @alvaroaleman Anyone else you wanted to review this? |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: b54b367b4cffcc758941308fee6ef0743c0ce46a |
Member
|
Yeah. I'll take a look once I get around to it |
sbueringer
reviewed
Jul 18, 2025
This change adds native server-side apply support to the client by extending it with an `Apply` method that takes an `runtime.ApplyConfiguration`.
This reverts commit ad1966a. This doesn't work, the server will always error on additional fields when using SSA, even when fieldValiation=None is configured.
k8s-ci-robot
removed
the
lgtm
Member
|
Thank you very much! Very nice! /lgtm @JoelSpeed do you want to take another look? |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 688c855c2d4653a12882dff29f1d7574ce02061d |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/hold cancel All good my side |
k8s-ci-robot
removed
the
do-not-merge/hold
This was referenced Jul 26, 2025
Closed
5 tasks
MaxRink
added a commit
to telekom/k8s-breakglass
that referenced
this pull request
Feb 6, 2026
Replace Create+AlreadyExists pattern with SSA for ResourceQuota, PDB, and workload deployment in debug_session_reconciler.go. Add ApplyTypedObject helper that converts typed k8s objects to unstructured for SSA. This is cleaner than Create+AlreadyExists and provides proper create-or-update semantics. Note: API Creates (BreakglassSession, DebugSession) are kept as-is: - AddBreakglassSession uses GenerateName (SSA needs known name) - CreateDebugSession needs AlreadyExists detection for 409 response Refs: kubernetes-sigs/controller-runtime#2981 Refs: kubernetes-sigs/controller-runtime#3321 Refs: kubernetes-sigs/controller-runtime#3253
MaxRink
added a commit
to telekom/k8s-breakglass
that referenced
this pull request
Feb 6, 2026
Replace Create+AlreadyExists pattern with SSA for ResourceQuota, PDB, and workload deployment in debug_session_reconciler.go. Add ApplyTypedObject helper that converts typed k8s objects to unstructured for SSA. This is cleaner than Create+AlreadyExists and provides proper create-or-update semantics. Note: API Creates (BreakglassSession, DebugSession) are kept as-is: - AddBreakglassSession uses GenerateName (SSA needs known name) - CreateDebugSession needs AlreadyExists detection for 409 response Refs: kubernetes-sigs/controller-runtime#2981 Refs: kubernetes-sigs/controller-runtime#3321 Refs: kubernetes-sigs/controller-runtime#3253
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds native server-side apply support to the client by extending it with an
Applymethod that takes aruntime.ApplyConfiguration.Ref #3183