fix: update controller-runtime to version v0.22.0#869
Conversation
Signed-off-by: MathiasBleimhofer <mathias.bleimhofer@deutschebahn.com>
|
Hey any updates on this? We really need this to update our providers to the latest controller-runtime :) |
|
Thanks! It'd help if you could open a draft PR against crossplane/crossplane that uses this branch (go mod replace statement) and the updated controller-runtime. That'll give us a sense of how much work (if any) we'll need to do in crossplane/crossplane to pick up this change. Other than that code changes here LGTM. |
|
@negz Like so: crossplane/crossplane#6802 |
negz
left a comment
There was a problem hiding this comment.
Thanks, LGTM!
Before I merge though - @erhancagirici, @sergenyalcin, any concerns from your POV as provider maintainers?
erhancagirici
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks OK from provider's perspective too. I'll double check by bumping it at upjet side, though it is not a blocker for this PR. If extra work is needed there, it can be done on its own pace.
|
crossplane/function-sdk-go#226 looks good to me so I think this is good to go. Thanks for chipping in to test this complicated change everyone. |
Description of your changes
This PR updates sigs.k8s.io/controller-runtime to version v0.22.0 and aligns related Kubernetes dependencies accordingly.
As part of this update, the Apply method was implemented for WrapperClient and MockClient to support the new Apply method added to the client.Client interface in controller-runtime v0.22.0.
controller-runtime: Add native SSA support
earthly +reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.