use native SSA support (controller-runtime v0.22) and remove unstructured conversion#875
Merged
use native SSA support (controller-runtime v0.22) and remove unstructured conversion#875
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the codebase to leverage native Server-Side Apply (SSA) support introduced in controller-runtime v0.22, eliminating the need for manual conversion to unstructured objects before applying Kubernetes resources.
Changes:
- Updated the
applyfunction to acceptruntime.ApplyConfigurationdirectly instead of a generic type - Removed unstructured object conversion logic from both the
applyfunction andreconcileV1StatefulSetmethod - Simplified type parameter syntax in
ptr.Tocalls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yamatcha
previously approved these changes
Jan 30, 2026
Co-authored-by: Soju Yamashita <soju-yamashita@cybozu.co.jp>
yamatcha
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the code to use native Server-Side Apply (SSA) support introduced in controller-runtime v0.22, eliminating the previously required conversion to unstructured objects.
Background
In controller-runtime v0.22, kubernetes-sigs/controller-runtime#3253 introduced the ability for the
client.Applymethod to acceptruntime.ApplyConfigurationdirectly. This eliminates the need for:runtime.DefaultUnstructuredConverter.ToUnstructured()client.ApplyConfigurationFromUnstructured()Changes
applyfunction signature to acceptruntime.ApplyConfigurationdirectlyThese changes make the code simpler and improve type safety.
References