- 
                Notifications
    You must be signed in to change notification settings 
- Fork 460
test: validate VMSS accelerated networking during E2E #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: validate VMSS accelerated networking during E2E #1242
Conversation
| Hi @jackfrancis. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. | 
| /ok-to-test | 
| #1245 has merged, please rebase to fix quota issues | 
0b17ca9    to
    e2f9250      
    Compare
  
    | /assign @mboersma | 
| /lgtm Thanks @jackfrancis! This should work fine, apologies for the hacky existing test. | 
| /approve | 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
Signed-off-by: Dipti Pai <diptipai89@outlook.com>
What type of PR is this?
What this PR does / why we need it:
This PR adds VMSS accelerated networking E2E coverage, mimic'ing the VM coverage. This is hacky, but I'm just following the existing pattern (apologies for any offense if I'm saying the existing implementation is hacky!)
Because this adds coverage where there is none, perhaps a functional, if hacky, solution is fine for now.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1015
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: