Merge pull request #1242 from jackfrancis/e2e-vmss-accelerated-networking

test: validate VMSS accelerated networking during E2E

Author: k8s-ci-robot

test/e2e/azure_accelnet.go

@@ -35,6 +35,20 @@ type AzureAcceleratedNetworkingSpecInput struct {
 	ClusterName string
 }
 
+// KnownAcceleratedNetworkingSupportedVMSKUs is a manually curated dictionary that maps VM SKUS to accelerated networking capabilities
+// NOTE: add SKUs being tested to this lookup table.
+var KnownAcceleratedNetworkingSupportedVMSKUs = map[compute.VirtualMachineSizeTypes]bool{
+	compute.VirtualMachineSizeTypesStandardB2ms:   false,
+	compute.VirtualMachineSizeTypesStandardD2V2:   true,
+	compute.VirtualMachineSizeTypesStandardD2V3:   false,
+	compute.VirtualMachineSizeTypesStandardD2sV3:  false,
+	compute.VirtualMachineSizeTypesStandardD4V2:   true,
+	compute.VirtualMachineSizeTypesStandardD4V3:   true,
+	compute.VirtualMachineSizeTypesStandardD8sV3:  true,
+	compute.VirtualMachineSizeTypesStandardNC6sV3: false,
+	compute.VirtualMachineSizeTypesStandardNV6:    false,
+}
+
 // AzureAcceleratedNetworkingSpec implements a test that verifies Azure VMs in a workload
 // cluster provisioned by CAPZ have accelerated networking enabled if they're capable of it.
 func AzureAcceleratedNetworkingSpec(ctx context.Context, inputGetter func() AzureAcceleratedNetworkingSpecInput) {
@@ -54,22 +68,14 @@ func AzureAcceleratedNetworkingSpec(ctx context.Context, inputGetter func() Azur
 	Expect(err).NotTo(HaveOccurred())
 	vmsClient := compute.NewVirtualMachinesClient(subscriptionID)
 	vmsClient.Authorizer = authorizer
+	vmssClient := compute.NewVirtualMachineScaleSetsClient(subscriptionID)
+	vmssClient.Authorizer = authorizer
+	vmssVMsClient := compute.NewVirtualMachineScaleSetVMsClient(subscriptionID)
+	vmssVMsClient.Authorizer = authorizer
 	nicsClient := network.NewInterfacesClient(subscriptionID)
 	nicsClient.Authorizer = authorizer
 
 	By("verifying EnableAcceleratedNetworking for the primary NIC of each VM")
-	// NOTE: add SKUs being tested to this lookup table.
-	acceleratedNetworking := map[compute.VirtualMachineSizeTypes]bool{
-		compute.VirtualMachineSizeTypesStandardB2ms:   false,
-		compute.VirtualMachineSizeTypesStandardD2V2:   true,
-		compute.VirtualMachineSizeTypesStandardD2V3:   false,
-		compute.VirtualMachineSizeTypesStandardD2sV3:  false,
-		compute.VirtualMachineSizeTypesStandardD4V2:   true,
-		compute.VirtualMachineSizeTypesStandardD4V3:   true,
-		compute.VirtualMachineSizeTypesStandardD8sV3:  true,
-		compute.VirtualMachineSizeTypesStandardNC6sV3: false,
-		compute.VirtualMachineSizeTypesStandardNV6:    false,
-	}
 	rgName := input.ClusterName
 	page, err := vmsClient.List(ctx, rgName)
 	Expect(err).NotTo(HaveOccurred())
@@ -79,10 +85,8 @@ func AzureAcceleratedNetworkingSpec(ctx context.Context, inputGetter func() Azur
 			sku := vm.HardwareProfile.VMSize
 			for _, nic := range *vm.NetworkProfile.NetworkInterfaces {
 				if nic.Primary != nil && *nic.Primary {
-					// verify that accelerated networking is enabled if the SKU is capable
-					nicInfo, err := nicsClient.Get(ctx, rgName, filepath.Base(*nic.ID), "")
+					capable, found, nicInfo, err := validateAcceleratedNetworkingCapabilityMatch(ctx, nicsClient, rgName, *nic.ID, sku)
 					Expect(err).NotTo(HaveOccurred())
-					capable, found := acceleratedNetworking[sku]
 					if !found {
 						fmt.Fprintf(GinkgoWriter, "SKU %s was not found, please add to the acceleratedNetworking lookup table.\n", sku)
 					} else {
@@ -95,4 +99,41 @@ func AzureAcceleratedNetworkingSpec(ctx context.Context, inputGetter func() Azur
 		err = page.NextWithContext(ctx)
 		Expect(err).NotTo(HaveOccurred())
 	}
+	By("verifying EnableAcceleratedNetworking for the primary NIC of each VMSS instance")
+	p, err := vmssClient.List(ctx, rgName)
+	Expect(err).NotTo(HaveOccurred())
+	for p.NotDone() {
+		for _, vmss := range p.Values() {
+			itr, err := vmssVMsClient.ListComplete(ctx, rgName, *vmss.Name, "", "", "")
+			var instances []compute.VirtualMachineScaleSetVM
+			for ; itr.NotDone(); err = itr.NextWithContext(ctx) {
+				Expect(err).NotTo(HaveOccurred())
+				vm := itr.Value()
+				sku := vm.HardwareProfile.VMSize
+				for _, nic := range *vm.NetworkProfile.NetworkInterfaces {
+					if nic.Primary != nil && *nic.Primary {
+						capable, found, nicInfo, err := validateAcceleratedNetworkingCapabilityMatch(ctx, nicsClient, rgName, *nic.ID, sku)
+						Expect(err).NotTo(HaveOccurred())
+						if !found {
+							fmt.Fprintf(GinkgoWriter, "SKU %s was not found, please add to the acceleratedNetworking lookup table.\n", sku)
+						} else {
+							Expect(capable).To(Equal(*nicInfo.EnableAcceleratedNetworking))
+						}
+					}
+				}
+				instances = append(instances, vm)
+			}
+		}
+	}
+}
+
+// validateAcceleratedNetworkingCapabilityMatch is a simple, common func to ensure that a NIC resource has the accelerated networking capability that we expect
+// because the NIC client is a common reference for both VM and VMSS resources, we can re-use this business logic in both above flows
+func validateAcceleratedNetworkingCapabilityMatch(ctx context.Context, nicsClient network.InterfacesClient, rgName, nicID string, sku compute.VirtualMachineSizeTypes) (bool, bool, network.Interface, error) {
+	nicInfo, err := nicsClient.Get(ctx, rgName, filepath.Base(nicID), "")
+	if err != nil {
+		return false, false, network.Interface{}, err
+	}
+	capable, found := KnownAcceleratedNetworkingSupportedVMSKUs[sku]
+	return capable, found, nicInfo, nil
 }