Skip to content

Update resize status #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2023
Merged

Update resize status #270

merged 4 commits into from
Aug 21, 2023

Conversation

@gnufied
Copy link
Contributor

@gnufied gnufied commented Mar 8, 2023 •
edited
Loading

Update code to use new resize status

Update recover from expansion failure to use newer APIs

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from andyzhangx and pohly March 8, 2023 21:25
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2023
@gnufied gnufied force-pushed the update-resize-status branch from 3d010cd to b73b0e9 Compare July 10, 2023 20:57
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2023
@msau42 msau42 mentioned this pull request Jul 18, 2023
Merged
@gnufied gnufied mentioned this pull request Aug 9, 2023
Closed
@gnufied gnufied force-pushed the update-resize-status branch from 99192d6 to 54f9738 Compare August 9, 2023 19:40
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 9, 2023
@gnufied
Copy link
Contributor Author

gnufied commented Aug 9, 2023

/assign @msau42 @sunnylovestiramisu

sunnylovestiramisu
sunnylovestiramisu reviewed Aug 9, 2023
View reviewed changes
pkg/controller/expand_and_recover.go
}
default:
// It is impossible for ResizeStatus to be nil and allocatedSize to be not nil but somehow
// It is impossible for ResizeStatus to be empty and allocatedSize to be not nil but somehow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the comment here is different from the other PR kubernetes/kubernetes#116335. Should this be empty or ""?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty and "" are same thing right? the main thing is - corresponding intree code doesn't ever actually gets executed because all volume plugins that support volume expansion are actually now migrated to CSI.

@sunnylovestiramisu
Copy link
Contributor

Other than the inconsistency of the comment in the code, the rest LGTM.

msau42
msau42 reviewed Aug 15, 2023
View reviewed changes
pkg/controller/resize_status.go Outdated
newPVC := pvc.DeepCopy()
newPVC.Status.Conditions = util.MergeResizeConditionsOfPVC(newPVC.Status.Conditions, conditions)
newPVC.Status.ResizeStatus = &controllerExpansionInProgress
newPVC.Status.AllocatedResourceStatuses = map[v1.ResourceName]v1.ClaimResourceStatus{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overrides status for other resources if they exist. Ditto throughout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@sunnylovestiramisu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1515a0b into kubernetes-csi:master Aug 21, 2023
@nixpanic nixpanic mentioned this pull request Aug 24, 2023
Closed
@mpatlasov mpatlasov mentioned this pull request Oct 8, 2023
Merged
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-resizer that referenced this pull request May 2, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 04965932..0a435bf9
1de7260 
0a435bf9 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34b Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e Bump golang to 1.24.0
f277d561 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a5 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 0a435bf987dd41314377818fa26a7bed006c01cd
@Aishwarya-Hebbar Aishwarya-Hebbar mentioned this pull request May 2, 2025
Merged
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-resizer that referenced this pull request Jul 7, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 04965932..74e066a8
754d92c 
74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7 Update CSI prow driver version to v1.17.0
0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af10153 update to go 1.24.4
f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db Remove chrishenzie from kubernetes-csi-reviewers
0a435bf9 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34b Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e Bump golang to 1.24.0
f277d561 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a5 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
@Aishwarya-Hebbar Aishwarya-Hebbar mentioned this pull request Jul 7, 2025
Open
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-resizer that referenced this pull request Jul 7, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 04965932..74e066a8
9c27ccf 
74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7 Update CSI prow driver version to v1.17.0
0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af10153 update to go 1.24.4
f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db Remove chrishenzie from kubernetes-csi-reviewers
0a435bf9 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34b Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e Bump golang to 1.24.0
f277d561 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a5 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-resizer that referenced this pull request Jul 14, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 04965932..74e066a8
2e69b66 
74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7 Update CSI prow driver version to v1.17.0
0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af10153 update to go 1.24.4
f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db Remove chrishenzie from kubernetes-csi-reviewers
0a435bf9 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34b Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e Bump golang to 1.24.0
f277d561 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a5 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
@Aishwarya-Hebbar Aishwarya-Hebbar mentioned this pull request Jul 14, 2025
Closed
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-resizer that referenced this pull request Jul 14, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 04965932..74e066a8
e94e6d4 
74e066a8 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7 Update CSI prow driver version to v1.17.0
0ee55894 Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af10153 update to go 1.24.4
f5fec3e3 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db Remove chrishenzie from kubernetes-csi-reviewers
0a435bf9 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34b Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e Bump golang to 1.24.0
f277d561 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a5 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 msau42 left review comments

@sunnylovestiramisu sunnylovestiramisu sunnylovestiramisu left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@pohly pohly Awaiting requested review from pohly

Assignees

@msau42 msau42

@sunnylovestiramisu sunnylovestiramisu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gnufied @k8s-ci-robot @k8s-triage-robot @sunnylovestiramisu @msau42