-
Couldn't load subscription status.
- Fork 148
Update dependency go modules for k8s v1.28.0-rc.0 #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency go modules for k8s v1.28.0-rc.0 #317
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sunnylovestiramisu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sunnylovestiramisu: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4dc65b7 to
72d93c7
Compare
|
hmm, should we update this with #270 ? I was doing that anyways as part of updating the sidecar |
|
@gnufied I was not aware of you are working on it already, and yep if you are taking care if it in your PR#270, we do not need to do it in this PR. |
|
Yeah I will have to modify some logic issues too while I am changing the code to use newer APIs. So it is best we handle this via #270 |
|
/close |
|
@sunnylovestiramisu: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p 1.28.0-rc.0