Skip to content

Conversation

@sunnylovestiramisu
Copy link
Contributor

Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p 1.28.0-rc.0

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunnylovestiramisu
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

@sunnylovestiramisu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-external-resizer-1-26-on-kubernetes-1-26 4dc65b7 link false /test pull-kubernetes-csi-external-resizer-1-26-on-kubernetes-1-26
pull-kubernetes-csi-external-resizer-unit 4dc65b7 link true /test pull-kubernetes-csi-external-resizer-unit
pull-kubernetes-csi-external-resizer-1-25-on-kubernetes-1-25 4dc65b7 link true /test pull-kubernetes-csi-external-resizer-1-25-on-kubernetes-1-25
pull-kubernetes-csi-external-resizer-1-24-on-kubernetes-1-24 4dc65b7 link true /test pull-kubernetes-csi-external-resizer-1-24-on-kubernetes-1-24

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnufied
Copy link
Contributor

gnufied commented Aug 9, 2023

hmm, should we update this with #270 ? I was doing that anyways as part of updating the sidecar

@sunnylovestiramisu
Copy link
Contributor Author

@gnufied I was not aware of you are working on it already, and yep if you are taking care if it in your PR#270, we do not need to do it in this PR.

@gnufied
Copy link
Contributor

gnufied commented Aug 9, 2023

Yeah I will have to modify some logic issues too while I am changing the code to use newer APIs. So it is best we handle this via #270

@sunnylovestiramisu
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@sunnylovestiramisu: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants