-
Couldn't load subscription status.
- Fork 2.8k
Disable recoverVolumeExpansionFailure tests for now #30120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable recoverVolumeExpansionFailure tests for now #30120
Conversation
| - -- | ||
| - --check-leaked-resources | ||
| - --env=KUBE_FEATURE_GATES=AllAlpha=true,DisableCloudProviders=false,DisableKubeletCloudCredentialProviders=false,InTreePluginGCEUnregister=false | ||
| - --env=KUBE_FEATURE_GATES=AllAlpha=true,RecoverVolumeExpansionFailure=false,DisableCloudProviders=false,DisableKubeletCloudCredentialProviders=false,InTreePluginGCEUnregister=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need to set this, skipping the tests for it should be sufficient, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay removed. Just FYI, the reason for dropping the feature-gate was, once we had a bug where if feature-gate is enabled in k8s (including kubelet) but external-resizer is older, then kubelet won't start resizing a volume until nodeResizePending is true. But then we fixed it, so we should be good.
f13cbeb to
332757b
Compare
|
/lgtm |
|
/assign @cheftako @andrewsykim |
|
After kubernetes-csi/external-resizer#270 merges and we cut a new resizer, we can update and re-enable the test |
|
/lgtm based on msau42's explanation. (And that its alpha feature testing) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gnufied: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We need a newer version of external-resizer for these tests to work.