Skip to content

Conversation

@gnufied
Copy link
Member

@gnufied gnufied commented Jul 18, 2023

We need a newer version of external-resizer for these tests to work.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 18, 2023
- --
- --check-leaked-resources
- --env=KUBE_FEATURE_GATES=AllAlpha=true,DisableCloudProviders=false,DisableKubeletCloudCredentialProviders=false,InTreePluginGCEUnregister=false
- --env=KUBE_FEATURE_GATES=AllAlpha=true,RecoverVolumeExpansionFailure=false,DisableCloudProviders=false,DisableKubeletCloudCredentialProviders=false,InTreePluginGCEUnregister=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to set this, skipping the tests for it should be sufficient, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay removed. Just FYI, the reason for dropping the feature-gate was, once we had a bug where if feature-gate is enabled in k8s (including kubelet) but external-resizer is older, then kubelet won't start resizing a volume until nodeResizePending is true. But then we fixed it, so we should be good.

@gnufied gnufied force-pushed the skip-expansion-recovery-tests-for-now branch from f13cbeb to 332757b Compare July 18, 2023 18:27
@liggitt
Copy link
Member

liggitt commented Jul 18, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@gnufied
Copy link
Member Author

gnufied commented Jul 18, 2023

/assign @cheftako @andrewsykim

@msau42
Copy link
Member

msau42 commented Jul 18, 2023

After kubernetes-csi/external-resizer#270 merges and we cut a new resizer, we can update and re-enable the test

@cheftako
Copy link
Member

/lgtm based on msau42's explanation. (And that its alpha feature testing)
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit c9a83c8 into kubernetes:master Jul 18, 2023
@k8s-ci-robot
Copy link
Contributor

@gnufied: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

We need a newer version of external-resizer for these tests to work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants