Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug tfma failure #91

Merged
merged 4 commits into from
Nov 6, 2018
Merged

debug tfma failure #91

merged 4 commits into from
Nov 6, 2018

Conversation

gaoning777
Copy link
Contributor

@gaoning777 gaoning777 commented Nov 6, 2018

This change is Reviewable

@Ark-kun Ark-kun self-requested a review November 6, 2018 19:21
@gaoning777 gaoning777 changed the title [WIP] debug tfma failure debug tfma failure Nov 6, 2018
@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 6, 2018

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 6, 2018

/approve

1 similar comment
@paveldournov
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, paveldournov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 077a060 into master Nov 6, 2018
@gaoning777 gaoning777 deleted the ngao/tfma-bug branch November 6, 2018 21:36
k8s-ci-robot pushed a commit that referenced this pull request Nov 7, 2018
* Moves docs from the /samples README to the wiki

I've copied all the info from the googleprivate/samples README.md to the wiki. This PR removes most of the content from the README, adds a simple introduction, and points people to the wiki docs for further information.

Relevant wiki files:
https://github.com/kubeflow/pipelines/wiki/Deploy-the-Kubeflow-Pipelines-Service
https://github.com/kubeflow/pipelines/wiki/Build-a-Pipeline
https://github.com/kubeflow/pipelines/wiki/Build-Your-Own-Component

* SDK/Tests/Components - Improve temporary file handling (#37)

* Improve temporary file handling in python op tests

* More small temp path fixes

* Fix tfx name bug in the tfma sample test (#67)

* fix tfx name bug

* update release build for the data publish

* SDK/DSL/Compiler - Fixed compilation of dsl.Condition (#28)

* Fixed compilation of dsl.Conditional
The compiler no longer produced intermediate steps.

* Got rid of _create_new_groups

* Changed the sub_group.type check

* Fix tfx name bug in the tfma sample test (#67)

* fix tfx name bug

* update release build for the data publish

* Build Python SDK in the releasing (#70)

* publish python sdk in the cloud build

* update cloudbuild

* adjust output path

* add dependency for buildapiserver

* mlp -> kfp.dsl (#88)

* Removed instruction to clone the repo.

* Changed link to samples doc on wiki.

* Add %%docker magic to jupyter kernel. It helps submitting a docker build job more easily with one cell. (#72)

* fix miscellaneous List API issue (#90)

* fix

* Update job_store.go

* Update run_store.go

* Update presubmit-tests.sh

* Update job_store.go

* Moves docs from pipelines main README to wiki (#83)

I've copied all the info from the kubeflow/pipelines README.md to the wiki. This PR removes most of the content from the README, adds a simple introduction, and points people to the wiki docs for further information.

Relevant wiki files:
https://github.com/kubeflow/pipelines/wiki
https://github.com/kubeflow/pipelines/wiki/Deploy-the-Kubeflow-Pipelines-Service
https://github.com/kubeflow/pipelines/wiki/Build-a-Pipeline

* SDK/DSL/Compiler - Reverted fix of dsl.Condition until the UI is ready. (#94)

* sort by run display name by default (#96)

* CSS changes for nav menu and tables (#99)

* debug tfma failure (#91)

* debug tfma failure

* tft version bug

* minor fix

* comment the test validation

* Fix validation check for maximum size limit (#104)

* Fixed the Minikube tests after moving to the new repo (#98)

* Don't barf when experiment name is already used (#101)

* don't barf when experiment name is already used

* make mock backend use case insensitive names

* ExperimentList tests, use immer.js (#86)

* experiment list tests

* use produce in more places

* remove extra test

* remove extra import

* Use the experiment's resource reference in the listJobs request (#105)

* use the experiment's resource reference in the listJobs request

* fix test import

* Add Ning and Alexey to OWNERS for components, samples and sample-test (#102)

* Compile samples instead of hard code them in API server (#76)

* compile samples

* update logging

* update description

* update sample

* add immediate value sample

* revert

* fail fast if the samples are failed to load

* comment

* address comments

* comment out

* update command

* comments

* Account for padding in metric progress fill (#107)

* Account for padding in metric progress fill

* small mock backend fix

* move to css classes, add color

* changes to breadcrumb style

* increase width of summary card

* tests

* merge tests

* First integration test for the ML Pipeline CLI (Pipeline List). (#81)

* First integration test for the ML Pipeline CLI (Pipeline List).

* Fixing an issue with an undefined variable

* Adding the --debug flag to help with debugging.

* Changing the namespace to Kubeflow.

* Add tests for the NewExperiment page (#109)

* Add tests for the NewExperiment page

* Fix test name

* Remove obsolete tests

* Clean up

* add xgboost: migrate from the old repo (#46)

* migrate from the old repo

* fix bug: accidentally override tfma test

* add tfma test back

* add tfma back

* typo fix

* fix small typo

* if job fails, exit after logs are output

* Remove CMLE sample for now since we are waiting for a service fix to support TPU. (#113)

* image tag update for release (#114)

* update image tag for new releases

* add more

* delete the accidentaly added sample

* fix typo (#116)

* Fix an issue that %%docker doesn't work. (#119)

* updated favicon to monochrome color (#118)

* Expanded row changes (#120)

* updated favicon to monochrome color

* simple CSS changes to expanded row

* Removed mentions of ark7 in tests (#111)

* Add basic sample tests (#79)

* add sequential sample test

* add condition basic sample

* reuse script

* add all the other basic tests

* update sample test dockerfile to add run_basic_test file

* write test output

* typo bug
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* sklearn tests and refactor

* adding successful test executions

* fixing based on review comments

* adding static type checking as part of maketest
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
* fix test cases

* add eof newline

* fix file restructure

* Generalize for special cases
Generalize for any nested pipeline or pipeline without a decorator as long as there is a config file with the necessary information to compile the pipelines

* Add more clear error throwing
also fix test_kfp_samples_report.txt

* Check for special pipelines from config file

* Add comment
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
feat(backend): Source ObjStore Creds from Env in Tekton Template
HumairAK added a commit to HumairAK/data-science-pipelines that referenced this pull request Oct 28, 2024
UPSTREAM: <carry>: Fixed importer component when podToPodTLS is true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants