Add %%docker magic to jupyter kernel. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild job more easily with one cell.
|
@gaoning777, I need /lgtm and /approve. |
|
/lgtm |
|
@qimingj: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@qimingj: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qimingj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/lgtm |
|
/retest |
Ark-kun
reviewed
Nov 6, 2018
| try: | ||
| import IPython | ||
| import IPython.core.magic | ||
| except ImportError: |
There was a problem hiding this comment.
This breaks Python's official unittest module when it's applied to our standard layout.
|
This code does not have any tests for user-facing API. |
|
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 7, 2018
* Moves docs from the /samples README to the wiki I've copied all the info from the googleprivate/samples README.md to the wiki. This PR removes most of the content from the README, adds a simple introduction, and points people to the wiki docs for further information. Relevant wiki files: https://github.com/kubeflow/pipelines/wiki/Deploy-the-Kubeflow-Pipelines-Service https://github.com/kubeflow/pipelines/wiki/Build-a-Pipeline https://github.com/kubeflow/pipelines/wiki/Build-Your-Own-Component * SDK/Tests/Components - Improve temporary file handling (#37) * Improve temporary file handling in python op tests * More small temp path fixes * Fix tfx name bug in the tfma sample test (#67) * fix tfx name bug * update release build for the data publish * SDK/DSL/Compiler - Fixed compilation of dsl.Condition (#28) * Fixed compilation of dsl.Conditional The compiler no longer produced intermediate steps. * Got rid of _create_new_groups * Changed the sub_group.type check * Fix tfx name bug in the tfma sample test (#67) * fix tfx name bug * update release build for the data publish * Build Python SDK in the releasing (#70) * publish python sdk in the cloud build * update cloudbuild * adjust output path * add dependency for buildapiserver * mlp -> kfp.dsl (#88) * Removed instruction to clone the repo. * Changed link to samples doc on wiki. * Add %%docker magic to jupyter kernel. It helps submitting a docker build job more easily with one cell. (#72) * fix miscellaneous List API issue (#90) * fix * Update job_store.go * Update run_store.go * Update presubmit-tests.sh * Update job_store.go * Moves docs from pipelines main README to wiki (#83) I've copied all the info from the kubeflow/pipelines README.md to the wiki. This PR removes most of the content from the README, adds a simple introduction, and points people to the wiki docs for further information. Relevant wiki files: https://github.com/kubeflow/pipelines/wiki https://github.com/kubeflow/pipelines/wiki/Deploy-the-Kubeflow-Pipelines-Service https://github.com/kubeflow/pipelines/wiki/Build-a-Pipeline * SDK/DSL/Compiler - Reverted fix of dsl.Condition until the UI is ready. (#94) * sort by run display name by default (#96) * CSS changes for nav menu and tables (#99) * debug tfma failure (#91) * debug tfma failure * tft version bug * minor fix * comment the test validation * Fix validation check for maximum size limit (#104) * Fixed the Minikube tests after moving to the new repo (#98) * Don't barf when experiment name is already used (#101) * don't barf when experiment name is already used * make mock backend use case insensitive names * ExperimentList tests, use immer.js (#86) * experiment list tests * use produce in more places * remove extra test * remove extra import * Use the experiment's resource reference in the listJobs request (#105) * use the experiment's resource reference in the listJobs request * fix test import * Add Ning and Alexey to OWNERS for components, samples and sample-test (#102) * Compile samples instead of hard code them in API server (#76) * compile samples * update logging * update description * update sample * add immediate value sample * revert * fail fast if the samples are failed to load * comment * address comments * comment out * update command * comments * Account for padding in metric progress fill (#107) * Account for padding in metric progress fill * small mock backend fix * move to css classes, add color * changes to breadcrumb style * increase width of summary card * tests * merge tests * First integration test for the ML Pipeline CLI (Pipeline List). (#81) * First integration test for the ML Pipeline CLI (Pipeline List). * Fixing an issue with an undefined variable * Adding the --debug flag to help with debugging. * Changing the namespace to Kubeflow. * Add tests for the NewExperiment page (#109) * Add tests for the NewExperiment page * Fix test name * Remove obsolete tests * Clean up * add xgboost: migrate from the old repo (#46) * migrate from the old repo * fix bug: accidentally override tfma test * add tfma test back * add tfma back * typo fix * fix small typo * if job fails, exit after logs are output * Remove CMLE sample for now since we are waiting for a service fix to support TPU. (#113) * image tag update for release (#114) * update image tag for new releases * add more * delete the accidentaly added sample * fix typo (#116) * Fix an issue that %%docker doesn't work. (#119) * updated favicon to monochrome color (#118) * Expanded row changes (#120) * updated favicon to monochrome color * simple CSS changes to expanded row * Removed mentions of ark7 in tests (#111) * Add basic sample tests (#79) * add sequential sample test * add condition basic sample * reuse script * add all the other basic tests * update sample test dockerfile to add run_basic_test file * write test output * typo bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It helps submitting a docker build job more easily with one cell:
This change is