Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves docs from the /samples README to the wiki #84

Merged
merged 34 commits into from
Nov 7, 2018

Conversation

sarahmaddox
Copy link
Contributor

@sarahmaddox sarahmaddox commented Nov 6, 2018

I've copied all the info from the googleprivate/samples README.md to the wiki. This PR removes most of the content from the README, adds a simple introduction, and points people to the wiki docs for further information.

Relevant wiki files:
https://github.com/kubeflow/pipelines/wiki/Deploy-the-Kubeflow-Pipelines-Service
https://github.com/kubeflow/pipelines/wiki/Build-a-Pipeline
https://github.com/kubeflow/pipelines/wiki/Build-Your-Own-Component


This change is Reviewable

I've copied all the info from the googleprivate/samples README.md to the wiki. This PR removes most of the content from the README, adds a simple introduction, and points people to the wiki docs for further information.

Relevant wiki files:
https://github.com/kubeflow/pipelines/wiki/Deploy-the-Kubeflow-Pipelines-Service
https://github.com/kubeflow/pipelines/wiki/Build-a-Pipeline
https://github.com/kubeflow/pipelines/wiki/Build-Your-Own-Component
Ark-kun and others added 4 commits November 5, 2018 23:44
* Improve temporary file handling in python op tests

* More small temp path fixes

* Fix tfx name bug in the tfma sample test (#67)

* fix tfx name bug

* update release build for the data publish
* Fixed compilation of dsl.Conditional
The compiler no longer produced intermediate steps.

* Got rid of _create_new_groups

* Changed the sub_group.type check

* Fix tfx name bug in the tfma sample test (#67)

* fix tfx name bug

* update release build for the data publish
* publish python sdk in the cloud build

* update cloudbuild

* adjust output path

* add dependency for buildapiserver
samples/README.md Outdated Show resolved Hide resolved
sarahmaddox and others added 5 commits November 6, 2018 17:51
* fix

* Update job_store.go

* Update run_store.go

* Update presubmit-tests.sh

* Update job_store.go
I've copied all the info from the kubeflow/pipelines README.md to the wiki. This PR removes most of the content from the README, adds a simple introduction, and points people to the wiki docs for further information.

Relevant wiki files:
https://github.com/kubeflow/pipelines/wiki
https://github.com/kubeflow/pipelines/wiki/Deploy-the-Kubeflow-Pipelines-Service
https://github.com/kubeflow/pipelines/wiki/Build-a-Pipeline
@vicaire
Copy link
Contributor

vicaire commented Nov 6, 2018

/lgtm

@vicaire
Copy link
Contributor

vicaire commented Nov 6, 2018

/approved

@vicaire
Copy link
Contributor

vicaire commented Nov 6, 2018

/retest

vicaire and others added 2 commits November 6, 2018 16:56
* First integration test for the ML Pipeline CLI (Pipeline List).

* Fixing an issue with an undefined variable

* Adding the --debug flag to help with debugging.

* Changing the namespace to Kubeflow.
* Add tests for the NewExperiment page

* Fix test name

* Remove obsolete tests

* Clean up
@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 7, 2018

/retest

gaoning777 and others added 9 commits November 6, 2018 17:15
* migrate from the old repo

* fix bug: accidentally override tfma test

* add tfma test back

* add tfma back

* typo fix

* fix small typo

* if job fails, exit after logs are output
* update image tag for new releases

* add more

* delete the accidentaly added sample
* updated favicon to monochrome color

* simple CSS changes to expanded row
* add sequential sample test

* add condition basic sample

* reuse script

* add all the other basic tests

* update sample test dockerfile to add run_basic_test file

* write test output

* typo bug
@sarahmaddox
Copy link
Contributor Author

/retest

@sarahmaddox
Copy link
Contributor Author

The test is failing due to insufficient quota.

@IronPan
Copy link
Member

IronPan commented Nov 7, 2018

/retest

@IronPan
Copy link
Member

IronPan commented Nov 7, 2018

/test mlpipeline-presubmit-e2e-test
/test mlpipeline-presubmit-sample-test

@IronPan
Copy link
Member

IronPan commented Nov 7, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 63e9c54 into master Nov 7, 2018
@IronPan IronPan deleted the sarahmaddox-samples-readme branch November 8, 2018 00:32
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
* Add conditional functionality
Adds conditional functionality except for having condition parameters being passed in from task outputs

* Remove extra parameter passing functionality

* Cleanup

* Add test example and update test report
HumairAK added a commit to HumairAK/data-science-pipelines that referenced this pull request Oct 17, 2024
UPSTREAM: <carry>: Fix Critical/High CVEs for tektoncd go modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.