Improve TFX Taxi Sample and Components. #512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongye-sun
approved these changes
Dec 11, 2018
| if args.target_lambda: | ||
| df['target'] = df.apply(eval(args.target_lambda), axis=1) | ||
|
|
||
| # Convert "True" to "True_" and "False" to "False_" for frontend to work. |
There was a problem hiding this comment.
This looks very hacky. Could you add a bug ID here to explain why it's needed?
There was a problem hiding this comment.
We are still investigating. #446. Will add that to comments
components/local/roc/src/roc.py
Outdated
| parser.add_argument('--target_lambda', type=str, | ||
| help='a lambda function as a string to determine positive or negative.' + | ||
| 'For example, "lambda x: x[\'a\'] and x[\'b\']". If missing, ' + | ||
| 'trueclass must be set.') |
There was a problem hiding this comment.
and input must have a target column.
| '--output', '%s/{{workflow.name}}/roc' % output, | ||
| '--predictions', predictions, | ||
| '--target_lambda', """lambda x: 1 if (x['target'] > x['fare'] * 0.2) else 0""", | ||
| '--trueclass', 'true', |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
…and E2E clusters (kubeflow#512) * cleanup_ci needs to use different expiration times for auto deployed and E2E clusters * The auto deployed clusters are now using unique names rather than being recycled and we rely on cleanup_ci.py to GC old auto-deployments (kubeflow#444) * To support this we need to use variable expiration times. * Deployments created by tests should expire as soon as the test is done (so 1-2 hours) * But auto-deployed clusters need to live longer * There are only refreshed periodically by a cron job (~8 hours) we don't want to delete the cluster before a new one is deployed because we need a cluster for the example tests * We want to leave the clusters up as long as we can to facilitate debugging by people working on example tests. Related to kubeflow#444 * Address reviewer comments.
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Fix typo in resources * Allow number of workers to be specified for Tornando * remove comment
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
…p CRs for the users (kubeflow#512) * add auto apply custom task CRs before pipelineRun creation * fix lint * store loop resource in ordered dict * Update kfp-admin-guide.md * sorted pipeline params to avoid randomness * sorted pipeline params to avoid randomness * regenerate tests * convert template string from yaml to json * regenerate tests * clean up unnecessary helper function * resolve merge conflicts * resolve merge conflicts * remove unnecessary go mod package * only opt-in to embed the recursion loop annotations * only opt-in to embed the recursion loop annotations * enable opt-in only via package variable * add example for how to inline recursive loops * resolve conflicts * regenerate tests * make auto generate and apply recursive pipelineloop in annotations as default * move parameter sorting to the end * add parameter sorting for recursion loops * sort recursive task parameters * add more details on how to opt-out auto apply custom resource
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is