Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile to add licenses using Go modules. #674

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

neuromage
Copy link
Contributor

@neuromage neuromage commented Jan 13, 2019

This change is Reviewable

@neuromage
Copy link
Contributor Author

/assign @IronPan
/cc @vicaire

There are changes in the license file seemingly caused by the order of licenses used to create it, which seems to have changed. I also see a change in the go.sum file, which only happened when I did go mod vendor. This is a change I don't fully understand either. But I think we need this to ensure our license files are up to date.

@IronPan
Copy link
Member

IronPan commented Jan 14, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan, neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6cce1bc into kubeflow:master Jan 14, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants