Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion Matrix UI Doesn't Work if My Labels are "True", "False" #446

Closed
qimingj opened this issue Dec 3, 2018 · 2 comments
Closed

Confusion Matrix UI Doesn't Work if My Labels are "True", "False" #446

qimingj opened this issue Dec 3, 2018 · 2 comments

Comments

@qimingj
Copy link
Contributor

qimingj commented Dec 3, 2018

For example, if your metadata is like:

metadata = {
'outputs' : [{
'type': 'confusion_matrix',
'storage': 'gcs',
'format': 'csv',
'schema': [
{'name': 'target', 'type': 'CATEGORY'},
{'name': 'predicted', 'type': 'CATEGORY'},
{'name': 'count', 'type': 'NUMBER'},
],
'source': cm_file,
'labels': ['True', 'False'],
}]
}

And if your Data is like:

True, True, 100
True, False, 20
False, True, 10,
False, False, 200

UI won't work. Probably because the serialization and deserialization of metadata converts string to boolean, and when parsing the actual data it does not do the same.

@yebrahim
Copy link
Contributor

yebrahim commented Dec 5, 2018

This works for me, except that it complains about the source field. If I set it properly to some GCS source it works fine.

@qimingj
Copy link
Contributor Author

qimingj commented Dec 12, 2018

turns out it is the saved metadata problem. The sample metadata I gave does not match the reality. In reality it is:

...
'labels': [True, False],
...

and it is saved to json file as boolean. I will fix it in the CM component. Sorry about the incorrect information!

@qimingj qimingj closed this as completed Dec 12, 2018
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
* Explainer virtual service cannot work

* Fix typo error
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants