-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom visualization support for Python based visualizations #1929
Add custom visualization support for Python based visualizations #1929
Conversation
cd319b8
to
3dc7b1a
Compare
/assign @IronPan @rileyjbauer @neuromage |
/retest |
1 similar comment
/retest |
* Added tests to ensure Editor component is visible when specifying visualization type * Updated test to properly validate provided source is rendered
…r every visualization type
c471e08
to
d90d698
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
||
if (!config) { | ||
return null; | ||
} | ||
|
||
const { isBusy = false, onGenerate } = config; | ||
|
||
// Only allow a visualization to be generated if one is not already being |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the comments.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Waiting for #1925 to be merged.
This change is