Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom visualization support for Python based visualizations #1929

Merged
merged 8 commits into from
Aug 25, 2019

Conversation

ajchili
Copy link
Member

@ajchili ajchili commented Aug 22, 2019

Waiting for #1925 to be merged.


This change is Reviewable

@ajchili ajchili force-pushed the ajchili/custom-visualizations branch from cd319b8 to 3dc7b1a Compare August 23, 2019 23:30
@ajchili ajchili changed the title [WIP] Add custom visualization support for Python based visualizations Add custom visualization support for Python based visualizations Aug 24, 2019
@ajchili
Copy link
Member Author

ajchili commented Aug 24, 2019

/assign @IronPan @rileyjbauer @neuromage

@ajchili
Copy link
Member Author

ajchili commented Aug 24, 2019

/retest

1 similar comment
@ajchili
Copy link
Member Author

ajchili commented Aug 24, 2019

/retest

@ajchili ajchili force-pushed the ajchili/custom-visualizations branch from c471e08 to d90d698 Compare August 24, 2019 17:37
Copy link
Contributor

@neuromage neuromage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve


if (!config) {
return null;
}

const { isBusy = false, onGenerate } = config;

// Only allow a visualization to be generated if one is not already being
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the comments.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neuromage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3d69062 into kubeflow:master Aug 25, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants