Exclude visualization types from flake8 testing #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @IronPan |
ajchili
force-pushed
the
ajchili/flake8-update-exclude-list
branch
from
3a1d390
to
51fd473
Compare
ajchili
changed the title
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neuromage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
numerology
pushed a commit
to numerology/pipelines
that referenced
this pull request
Aug 25, 2019
* Moved visualization types to types subdirectory * Updated flake8 test to ignore types subdirectory (cherry picked from commit 677ffe2)
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…eflow#1925) * Intial commit for sdk replace fix Made changes to wait for the new replaced version to be ready Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fixed linting errors Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Removed print statement Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Made changes to use observed generation Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fixed issues with missing generation / observed generation Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Remove unnecessary sleep * Fix indentation Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for #1898 to be merged.
This change is